From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:51006)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Rkw9P-0000Tk-NM
	for qemu-devel@nongnu.org; Wed, 11 Jan 2012 06:15:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Rkw9I-0005fh-FQ
	for qemu-devel@nongnu.org; Wed, 11 Jan 2012 06:15:27 -0500
Received: from mail-qw0-f52.google.com ([209.85.216.52]:58687)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Rkw9I-0005fX-DG
	for qemu-devel@nongnu.org; Wed, 11 Jan 2012 06:15:20 -0500
Received: by qafl39 with SMTP id l39so378440qaf.4
	for <qemu-devel@nongnu.org>; Wed, 11 Jan 2012 03:15:19 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1326271428-15648-1-git-send-email-javier@dowhile0.org>
References: <1326271428-15648-1-git-send-email-javier@dowhile0.org>
Date: Wed, 11 Jan 2012 11:15:19 +0000
Message-ID: <CAFEAcA8nYo1P1d-riVippbGHZUcTM7cFMFhytns+KEj_LCY0Cg@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 1/1] hw: Add IGEPv2 board support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: qemu-devel@nongnu.org, linaro-toolchain <linaro-toolchain@lists.linaro.org>

On 11 January 2012 08:43, Javier Martinez Canillas <javier@dowhile0.org> wrote:
> Add ISEE IGEPv2 board definition (an OMAP3730 based board).
>
> Signed-off-by: Javier Martinez Canillas <javier@dowhile0.org>

It's polite to mention that patches are against qemu-linaro if you cc
qemu-devel.

So my initial reaction to this is to ask what the benefit is of adding another
basically-just-an-OMAP3 model. We already have beagle and overo,
and this is obviously just cut-n-paste from overo (it still has the comment
about "FAB revisions" which is specific to Overo, which doesn't give me a
great deal of confidence that this is actually correctly modelling the IGEPv2
rather than just something random which happens to be able to boot an
IGEPv2 kernel...)

GPLv2-only rather than v2-or-later is also going to be a problem, although
I appreciate that that's because you've based this on the v2-only overo.c
[which is going to be a problem for me later on when I try to upstream that :-)]

-- PMM