From: Peter Maydell <peter.maydell@linaro.org>
To: Samuel Seay <lightningth@gmail.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Change to correct PowerPC on a 64bit host
Date: Wed, 2 Jan 2013 14:53:55 +0000 [thread overview]
Message-ID: <CAFEAcA8neqHbyk07wZs2HhN0FcmeYjAswuYgEmnfoVNeamvvZg@mail.gmail.com> (raw)
In-Reply-To: <CADwyeC8_=aC+3aRo-WT=VbRUkpKhghCPbKXmyG4qMJcz5y=-RQ@mail.gmail.com>
On 2 January 2013 14:34, Samuel Seay <lightningth@gmail.com> wrote:
> I did not catch that, somehow I managed to invert the logic when looking at
> it. Maybe a g2h() (such a macro exist? what would be the proper method?)
> around the newsp value would do it.
You want to use put_user() (without the __) -- this (a) takes a guest address
and (b) does the error checking for unwritable address, which __put_user
does not. [Don't be fooled by all the err |= __put_user code, this is bogus
because __put_user never fails.]
> I'll redo that this evening and attempt
> to submit a newer patch. Considering I don't have direct internet access in
> the VM, any suggestions to make everyone happy on the patch submission?
Use git format-patch in the VM to write the patch to file, copy the file out of
the VM and use git send-email to actually send it.
-- PMM
prev parent reply other threads:[~2013-01-02 14:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-02 4:58 [Qemu-devel] [PATCH] Change to correct PowerPC on a 64bit host Samuel Seay
2013-01-02 11:44 ` Andreas Färber
2013-01-02 12:00 ` Peter Maydell
2013-01-02 13:01 ` Samuel Seay
2013-01-02 14:02 ` Peter Maydell
2013-01-02 14:34 ` Samuel Seay
2013-01-02 14:47 ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
2013-01-02 14:53 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8neqHbyk07wZs2HhN0FcmeYjAswuYgEmnfoVNeamvvZg@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=lightningth@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).