From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8UW9-0007Td-2Z for qemu-devel@nongnu.org; Tue, 06 Jan 2015 08:49:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y8UW5-00019X-P7 for qemu-devel@nongnu.org; Tue, 06 Jan 2015 08:49:52 -0500 Received: from mail-lb0-f170.google.com ([209.85.217.170]:53534) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8UW5-00019L-HI for qemu-devel@nongnu.org; Tue, 06 Jan 2015 08:49:49 -0500 Received: by mail-lb0-f170.google.com with SMTP id 10so19664826lbg.1 for ; Tue, 06 Jan 2015 05:49:47 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1420449663-4542-1-git-send-email-ghammer@redhat.com> References: <1420449663-4542-1-git-send-email-ghammer@redhat.com> From: Peter Maydell Date: Tue, 6 Jan 2015 13:49:27 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] char: disable stdio echo on resume from suspend. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gal Hammer Cc: Paolo Bonzini , QEMU Developers On 5 January 2015 at 09:21, Gal Hammer wrote: > The monitor's auto-completion feature stopped working when stdio is used > as an input and qemu was resumed after it was suspended (using ctrl-z). > > Signed-off-by: Gal Hammer > --- > qemu-char.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/qemu-char.c b/qemu-char.c > index ef84b53..786df33 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -1113,12 +1113,22 @@ static int old_fd0_flags; > static bool stdio_in_use; > static bool stdio_allow_signal; > > +static void qemu_chr_set_echo_stdio(CharDriverState *chr, bool echo); > + > static void term_exit(void) > { > tcsetattr (0, TCSANOW, &oldtty); > fcntl(0, F_SETFL, old_fd0_flags); > } > > +static void term_stdio_handler(int sig) > +{ > + if (sig == SIGCONT) { ...why do we need this check? We don't register the function for any other signals... > + /* echo should be off after resume from suspend. */ > + qemu_chr_set_echo_stdio(NULL, false); Should echo really be always off, even if the thing using the char device had set it to on? > + } > +} > + > static void qemu_chr_set_echo_stdio(CharDriverState *chr, bool echo) > { > struct termios tty; > @@ -1165,6 +1175,7 @@ static CharDriverState *qemu_chr_open_stdio(ChardevStdio *opts) > tcgetattr(0, &oldtty); > qemu_set_nonblock(0); > atexit(term_exit); > + signal(SIGCONT, term_stdio_handler); This should probably be using sigaction() which is what we use elsewhere for signal handler registration. -- PMM