From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49819)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Z9cav-0002c3-Bo
	for qemu-devel@nongnu.org; Mon, 29 Jun 2015 13:11:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Z9cas-0007vL-2t
	for qemu-devel@nongnu.org; Mon, 29 Jun 2015 13:11:45 -0400
Received: from mail-vn0-f49.google.com ([209.85.216.49]:43586)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Z9car-0007v8-VF
	for qemu-devel@nongnu.org; Mon, 29 Jun 2015 13:11:42 -0400
Received: by vnbf190 with SMTP id f190so6605295vnb.10
	for <qemu-devel@nongnu.org>; Mon, 29 Jun 2015 10:11:41 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <C3D7DD34-3469-4A16-B6AA-63673CA30810@gmail.com>
References: <C3D7DD34-3469-4A16-B6AA-63673CA30810@gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 29 Jun 2015 18:11:22 +0100
Message-ID: <CAFEAcA8o1rDne5CS-h3vFd9482neKeucS9BsrDPqWeDktfXjxA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] raw-posix.c: cd_is_inserted()
 implementation for Mac OS X
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Programmingkid <programmingkidx@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel qemu-devel <qemu-devel@nongnu.org>, Qemu-block <qemu-block@nongnu.org>

On 29 June 2015 at 17:54, Programmingkid <programmingkidx@gmail.com> wrote:
> @@ -2365,6 +2384,10 @@ static BlockDriver bdrv_host_device = {
>      .bdrv_ioctl         = hdev_ioctl,
>      .bdrv_aio_ioctl     = hdev_aio_ioctl,
>  #endif
> +
> +#ifdef __APPLE__
> +    .bdrv_is_inserted   = cdrom_is_inserted,
> +#endif

Why isn't this handled by having a bdrv_host_cdrom,
like Linux and FreeBSD do for their CDROM support?

-- PMM