From: Peter Maydell <peter.maydell@linaro.org>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Peter Crosthwaite" <peter.crosthwaite@xilinx.com>,
"Andreas Färber" <afaerber@suse.de>,
"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Revert "nand: Don't inherit from Sysbus"
Date: Wed, 5 Feb 2014 14:28:31 +0000 [thread overview]
Message-ID: <CAFEAcA8oAGsUnKbtBm+Ceu06R0YJDjwaQ_k43ExfQKi8gBbOpA@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA_pX4V9hLCunENB4aooqJiWxZqTrBSNxtt5-TNOPDKoZQ@mail.gmail.com>
On 5 February 2014 13:00, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 5 February 2014 12:24, Markus Armbruster <armbru@redhat.com> wrote:
>> As to why it's complicated for Peter to fix, here's what Peter wrote:
>> "That series got very big on me with complications. I think near term
>> we just proceed with the revert. Sorry for the delay." I have no
>> reason to second-guess him.
>>
>> Promptly reverting patches that cause regressions when a fix isn't ready
>> is standard operating procedure. We can delay a revert a reasonable
>> amount of time to deliberate what to do, and perhaps find a fix. We did
>> that, and then some: four weeks. We should revert, and try again.
>> Neither harm nor shame in that.
>
> I agree in general here, which is why I'm going to apply this patch.
Following conversation on IRC and Andreas' recent patch:
given that the current state of affairs (ie 'info qtest crashes') has been
in master for six months, there doesn't seem to be a critically urgent
need to act immediately, so I'm going to give it a few days to check
that we have a consensus on the best way to deal with this.
thanks
-- PMM
next prev parent reply other threads:[~2014-02-05 14:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 8:39 [Qemu-devel] [PATCH] Revert "nand: Don't inherit from Sysbus" Markus Armbruster
2014-02-05 8:55 ` Andreas Färber
2014-02-05 12:24 ` Markus Armbruster
2014-02-05 13:00 ` Peter Maydell
2014-02-05 14:28 ` Peter Maydell [this message]
2014-02-05 15:00 ` Markus Armbruster
2014-02-05 15:48 ` Paolo Bonzini
2014-02-05 23:06 ` Peter Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8oAGsUnKbtBm+Ceu06R0YJDjwaQ_k43ExfQKi8gBbOpA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).