From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40024)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WRTOa-0005Zk-0X
	for qemu-devel@nongnu.org; Sat, 22 Mar 2014 17:24:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WRTOV-0002YU-4J
	for qemu-devel@nongnu.org; Sat, 22 Mar 2014 17:23:59 -0400
Received: from mail-la0-f46.google.com ([209.85.215.46]:38760)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WRTOU-0002YO-Ts
	for qemu-devel@nongnu.org; Sat, 22 Mar 2014 17:23:55 -0400
Received: by mail-la0-f46.google.com with SMTP id hr17so2591295lab.5
	for <qemu-devel@nongnu.org>; Sat, 22 Mar 2014 14:23:53 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <532DFAE8.90704@suse.de>
References: <1394088217-4504-1-git-send-email-aik@ozlabs.ru>
	<87bnxjo2f3.fsf@pixel.localdomain> <53228F11.1020801@ozlabs.ru>
	<532DF031.40209@suse.de>
	<CAFEAcA_oE0H6mkLmBpVri5B7OorEcqyOd+GpV+XfQSDnEsUjPw@mail.gmail.com>
	<532DFAE8.90704@suse.de>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Sat, 22 Mar 2014 21:23:33 +0000
Message-ID: <CAFEAcA8oQtF=ioW834GxpGuvjPvSZLgnm3tkv+hnnan0pi5E_w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] usb-ohci: add vmstate descriptor
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>, Mike Day <ncmike@ncultra.org>, Gerd Hoffmann <kraxel@gmail.com>, QEMU Developers <qemu-devel@nongnu.org>

On 22 March 2014 21:04, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
> Am 22.03.2014 21:54, schrieb Peter Maydell:
>> On 22 March 2014 20:18, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
>>> Because AFAIU
>>> migration is possible without VMSD, just not with VMSD that sets
>>> .unmigratable =3D 1.
>>
>> Well, the migration won't fail with an error, but on the destination
>> end you'll end up with a device in its reset state but a guest which
>> may think the device is in some other state. If the device was
>> quiescent and doesn't need complex setup it might cope, but
>> more likely is that that guest driver will fall over in a heap next
>> time you try to use it...
>
> Well, there is no OHCI state being added, only PCI state. So I'd be
> curious to know what in there is the problem because a general review of
> PCI devices might be due then - and ideally before we do the release.

Oops, I hadn't noticed that; this patch is incorrect, then, because
vmstate_ohci needs to include a line for the OHCIState, and we
need a second vmstate struct for the OHCIState.

thanks
-- PMM