From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46411) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WilU1-00045o-Aj for qemu-devel@nongnu.org; Fri, 09 May 2014 10:09:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WilTw-0007C3-U9 for qemu-devel@nongnu.org; Fri, 09 May 2014 10:09:05 -0400 Received: from mail-lb0-f175.google.com ([209.85.217.175]:50117) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WilTw-0007Bx-N0 for qemu-devel@nongnu.org; Fri, 09 May 2014 10:09:00 -0400 Received: by mail-lb0-f175.google.com with SMTP id l4so5385630lbv.6 for ; Fri, 09 May 2014 07:08:59 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <5363B8C2.6000700@twiddle.net> References: <1398713302-29657-1-git-send-email-rth@twiddle.net> <1398713302-29657-11-git-send-email-rth@twiddle.net> <5363B8C2.6000700@twiddle.net> From: Peter Maydell Date: Fri, 9 May 2014 15:08:39 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v3 10/16] tcg-arm: Define TCG_TARGET_INSN_UNIT_SIZE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: QEMU Developers On 2 May 2014 16:24, Richard Henderson wrote: > On 05/02/2014 08:19 AM, Peter Maydell wrote: >> This change also confused me but we're again relying on movi32 >> generating correct-but-inefficient code now, right? > > Yes. IMO if we want to do a constant pool, let's do a proper one, > not just in a few places. Fair enough. I don't care very much about pre-v7 hosts anyway... Reviewed-by: Peter Maydell -- PMM