From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47073) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aK7qW-0004FY-1g for qemu-devel@nongnu.org; Fri, 15 Jan 2016 12:07:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aK7qV-0004Et-5d for qemu-devel@nongnu.org; Fri, 15 Jan 2016 12:07:31 -0500 Received: from mail-vk0-x232.google.com ([2607:f8b0:400c:c05::232]:36113) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aK7qV-0004En-0Q for qemu-devel@nongnu.org; Fri, 15 Jan 2016 12:07:31 -0500 Received: by mail-vk0-x232.google.com with SMTP id n1so147362302vkb.3 for ; Fri, 15 Jan 2016 09:07:30 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <56992647.1080409@ilande.co.uk> References: <1452516028-25218-1-git-send-email-peter.maydell@linaro.org> <56992647.1080409@ilande.co.uk> From: Peter Maydell Date: Fri, 15 Jan 2016 17:07:11 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v2 0/8] target-sparc: Update to use VMStateDescription List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland Cc: Patch Tracking , Juan Quintela , QEMU Developers , Blue Swirl , Amit Shah , Paolo Bonzini On 15 January 2016 at 17:03, Mark Cave-Ayland wrote: > I've just run through some SPARC32 tests with this patchset applied - > testing a savevm/loadvm pair pre-patch and post-patch, and then a few > random tests with various OSs at random points during boot and no > regressions here, so: > > Tested-by: Mark Cave-Ayland Thanks. > The only minor nit I could see during review was that both patches 7 and > 8 bump the VMState revision for SPARC64, and given that before the last > patch in the set nothing works then is it just worth bumping once to > version 8 in patch 7 and let that be it? My general feeling is that there isn't a significant shortage of positive integers that would lead us to want to conserve them :-) If you prefer only bumping once you can do that when you apply the patches to your target-sparc queue if you like. thanks -- PMM