From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32920) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZNvL-0008AD-BD for qemu-devel@nongnu.org; Tue, 08 Sep 2015 14:47:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZNvI-0006IY-Ly for qemu-devel@nongnu.org; Tue, 08 Sep 2015 14:47:19 -0400 Received: from mail-yk0-f181.google.com ([209.85.160.181]:34792) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZNvI-0006IS-IG for qemu-devel@nongnu.org; Tue, 08 Sep 2015 14:47:16 -0400 Received: by ykdg206 with SMTP id g206so132891127ykd.1 for ; Tue, 08 Sep 2015 11:47:16 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1441173123-25540-18-git-send-email-rth@twiddle.net> References: <1441173123-25540-1-git-send-email-rth@twiddle.net> <1441173123-25540-18-git-send-email-rth@twiddle.net> From: Peter Maydell Date: Tue, 8 Sep 2015 19:46:56 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 17/20] tcg: Pass data argument to restore_state_to_opc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: Aurelien Jarno , QEMU Developers , dl.soluz@gmx.net, Artyom Tarasenko On 2 September 2015 at 06:52, Richard Henderson wrote: > The gen_opc_* arrays are already redundant with the data stored in > the insn_start arguments. Transition restore_state_to_opc to use > data from the later. Typo: "latter". > Signed-off-by: Richard Henderson > diff --git a/tcg/tcg.c b/tcg/tcg.c > index a44b834..d956f0b 100644 > --- a/tcg/tcg.c > +++ b/tcg/tcg.c > @@ -1007,7 +1007,6 @@ void tcg_dump_ops(TCGContext *s) > a = args[i]; > #endif > qemu_log(" " TARGET_FMT_lx, a); > - > } > } else if (c == INDEX_op_call) { > /* variable number of arguments */ Stray whitespace change. Otherwise Reviewed-by: Peter Maydell thanks -- PMM