[Qemu-devel] [PATCH] build-sys: update configure --enable/disable list

[Qemu-devel] [PATCH] build-sys: update configure --enable/disable list

[Marc-André Lureau]

Add some missing flags description.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 configure | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/configure b/configure
index 8d84919..352cbdd 100755
--- a/configure
+++ b/configure
@@ -1324,9 +1324,11 @@ disabled with --disable-FEATURE, default is enabled if available:
   guest-agent     build the QEMU Guest Agent
   guest-agent-msi build guest agent Windows MSI installation package
   pie             Position Independent Executables
+  tools           build tools (qemu-img, qemu-nbd, ivshmem-server...)
   modules         modules support
   debug-tcg       TCG debugging (default is disabled)
   debug-info      debugging information
+  qom-cast-debug  QOM debugging
   sparse          sparse checker
 
   gnutls          GNUTLS cryptography support
@@ -1359,10 +1361,14 @@ disabled with --disable-FEATURE, default is enabled if available:
   cap-ng          libcap-ng support
   attr            attr and xattr support
   vhost-net       vhost-net acceleration support
+  vhost-scsi      vhost-scsi acceleration support
   spice           spice
+  opengl          OpenGL support
+  virglrenderer   virgl 3d rendering
   rbd             rados block device (rbd)
   libiscsi        iscsi support
   libnfs          nfs support
+  xfsctl          xfsctl support
   smartcard       smartcard support (libcacard)
   libusb          libusb (for usb passthrough)
   usb-redir       usb network redirection support
-- 
2.9.0

Re: [Qemu-devel] [PATCH] build-sys: update configure --enable/disable list

[Peter Maydell]

On 12 August 2016 at 16:52, Marc-André Lureau
<marcandre.lureau@redhat.com> wrote:
> Add some missing flags description.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  configure | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/configure b/configure
> index 8d84919..352cbdd 100755
> --- a/configure
> +++ b/configure
> @@ -1324,9 +1324,11 @@ disabled with --disable-FEATURE, default is enabled if available:
>    guest-agent     build the QEMU Guest Agent
>    guest-agent-msi build guest agent Windows MSI installation package
>    pie             Position Independent Executables
> +  tools           build tools (qemu-img, qemu-nbd, ivshmem-server...)

I think this would be slightly clearer as "build the tools".

> +  virglrenderer   virgl 3d rendering

"3D".

thanks
-- PMM

Re: [Qemu-devel] [PATCH] build-sys: update configure --enable/disable list

[Marc-André Lureau]

Hi

----- Original Message -----
> On 12 August 2016 at 16:52, Marc-André Lureau
> <marcandre.lureau@redhat.com> wrote:
> > Add some missing flags description.
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > ---
> >  configure | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/configure b/configure
> > index 8d84919..352cbdd 100755
> > --- a/configure
> > +++ b/configure
> > @@ -1324,9 +1324,11 @@ disabled with --disable-FEATURE, default is enabled
> > if available:
> >    guest-agent     build the QEMU Guest Agent
> >    guest-agent-msi build guest agent Windows MSI installation package
> >    pie             Position Independent Executables
> > +  tools           build tools (qemu-img, qemu-nbd, ivshmem-server...)
> 
> I think this would be slightly clearer as "build the tools".

Ok, along with "build the guest agent" above change then?

> 
> > +  virglrenderer   virgl 3d rendering
> 
> "3D".
> 

ok

Re: [Qemu-devel] [PATCH] build-sys: update configure --enable/disable list

[Peter Maydell]

On 12 August 2016 at 17:48, Marc-André Lureau <mlureau@redhat.com> wrote:
> Hi
>
> ----- Original Message -----
>> On 12 August 2016 at 16:52, Marc-André Lureau
>> <marcandre.lureau@redhat.com> wrote:
>> > Add some missing flags description.
>> >
>> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>> > ---
>> >  configure | 6 ++++++
>> >  1 file changed, 6 insertions(+)
>> >
>> > diff --git a/configure b/configure
>> > index 8d84919..352cbdd 100755
>> > --- a/configure
>> > +++ b/configure
>> > @@ -1324,9 +1324,11 @@ disabled with --disable-FEATURE, default is enabled
>> > if available:
>> >    guest-agent     build the QEMU Guest Agent
>> >    guest-agent-msi build guest agent Windows MSI installation package
>> >    pie             Position Independent Executables
>> > +  tools           build tools (qemu-img, qemu-nbd, ivshmem-server...)
>>
>> I think this would be slightly clearer as "build the tools".
>
> Ok, along with "build the guest agent" above change then?

You can change that if you like. I just thought that it was
worth having the 'the' in the tools case because "build tools"
is a familiar noun phrase which is misleading here.

thanks
-- PMM