From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:40003)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Qtod0-0004OG-AL
	for qemu-devel@nongnu.org; Wed, 17 Aug 2011 18:30:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Qtocz-0003eg-CT
	for qemu-devel@nongnu.org; Wed, 17 Aug 2011 18:30:26 -0400
Received: from mail-pz0-f42.google.com ([209.85.210.42]:60514)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Qtocz-0003ea-55
	for qemu-devel@nongnu.org; Wed, 17 Aug 2011 18:30:25 -0400
Received: by pzk37 with SMTP id 37so2149466pzk.29
	for <qemu-devel@nongnu.org>; Wed, 17 Aug 2011 15:30:24 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1313104041-1641-9-git-send-email-rth@twiddle.net>
References: <1313104041-1641-1-git-send-email-rth@twiddle.net>
	<1313104041-1641-9-git-send-email-rth@twiddle.net>
Date: Wed, 17 Aug 2011 23:30:23 +0100
Message-ID: <CAFEAcA8p4SpPVHgyD2Zbzu7rCLbZZRMC2_MWa-dqhyVVovTgug@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 8/9] sm501: Pass address_space_mem to
	sm501_init.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org, avi@redhat.com

On 12 August 2011 00:07, Richard Henderson <rth@twiddle.net> wrote:
> diff --git a/hw/devices.h b/hw/devices.h
> index 07fda83..36c21e7 100644
> --- a/hw/devices.h
> +++ b/hw/devices.h
> @@ -1,6 +1,9 @@
> =C2=A0#ifndef QEMU_DEVICES_H
> =C2=A0#define QEMU_DEVICES_H
>
> +/* ??? Not all users of this file can include cpu-common.h. =C2=A0*/
> +typedef struct MemoryRegion MemoryRegion;
> +

This breaks compilation of Avi's memory-region branch:
In file included from /home/petmay01/git/qemu/hw/smc91c111.c:12:0:
/home/petmay01/git/qemu/hw/devices.h:5:29: error: redefinition of
typedef =E2=80=98MemoryRegion=E2=80=99
/home/petmay01/git/qemu/memory.h:29:29: note: previous declaration of
=E2=80=98MemoryRegion=E2=80=99 was here

-- PMM