From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YfvDU-0001TL-Ii for qemu-devel@nongnu.org; Wed, 08 Apr 2015 15:00:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YfvDO-0003zV-VH for qemu-devel@nongnu.org; Wed, 08 Apr 2015 15:00:48 -0400 Received: from mail-ie0-f177.google.com ([209.85.223.177]:33287) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YfvDO-0003zQ-Or for qemu-devel@nongnu.org; Wed, 08 Apr 2015 15:00:42 -0400 Received: by iebmp1 with SMTP id mp1so82649659ieb.0 for ; Wed, 08 Apr 2015 12:00:42 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1424212826-27606-2-git-send-email-mdroth@linux.vnet.ibm.com> References: <1424212826-27606-1-git-send-email-mdroth@linux.vnet.ibm.com> <1424212826-27606-2-git-send-email-mdroth@linux.vnet.ibm.com> From: Peter Maydell Date: Wed, 8 Apr 2015 20:00:21 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 01/10] qga: add guest-set-user-password command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: QEMU Developers On 17 February 2015 at 22:40, Michael Roth wrot= e: > From: "Daniel P. Berrange" > > Add a new 'guest-set-user-password' command for changing the password > +void qmp_guest_set_user_password(const char *username, > + const char *password, > + bool crypted, > + Error **errp) > +{ > + Error *local_err =3D NULL; > + char *passwd_path =3D NULL; > + pid_t pid; > + int status; > + int datafd[2] =3D { -1, -1 }; > + char *rawpasswddata =3D NULL; > + size_t rawpasswdlen; > + char *chpasswddata =3D NULL; > + size_t chpasswdlen; > + > + rawpasswddata =3D (char *)g_base64_decode(password, &rawpasswdlen); Hi. This seems to break certain kinds of compilation setups (the one I noticed was a -m32 compile to build 32-bit PPC binaries on a 64-bit PPC Fedora box): CC qga/commands-posix.o /home/pm215/qemu/qga/commands-posix.c: In function =E2=80=98qmp_guest_set_user_password=E2=80=99: /home/pm215/qemu/qga/commands-posix.c:1908:5: error: passing argument 2 of =E2=80=98g_base64_decode=E2=80=99 from incompatible pointer type [-Wer= ror] In file included from /usr/include/glib-2.0/glib.h:37:0, from /home/pm215/qemu/qga/commands-posix.c:14: /usr/include/glib-2.0/glib/gbase64.h:49:9: note: expected =E2=80=98gsize *= =E2=80=99 but argument is of type =E2=80=98size_t *=E2=80=99 It looks like you can't just assume that size_t and gsize are the same thing. Compare commit 3d1bba20 which fixed some previous instances of this. thanks -- PMM