From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B067AC433FE for ; Mon, 13 Sep 2021 14:26:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 733E460F26 for ; Mon, 13 Sep 2021 14:26:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 733E460F26 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:38576 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPmuY-0007V1-Ki for qemu-devel@archiver.kernel.org; Mon, 13 Sep 2021 10:26:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50758) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPmru-0002Vc-9W for qemu-devel@nongnu.org; Mon, 13 Sep 2021 10:23:34 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:40876) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mPmrs-0006jZ-Or for qemu-devel@nongnu.org; Mon, 13 Sep 2021 10:23:33 -0400 Received: by mail-wr1-x42e.google.com with SMTP id q26so14993330wrc.7 for ; Mon, 13 Sep 2021 07:23:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=G/oXdG+K/mn7k+A9gPyTnR0ScqfyVqdSsawxB342AdQ=; b=aa47cwxoqLvgSeQcR6/VLipx63NWLnoUaKUUsR4TY+SEhDePfi1lL0pHheGqBCvOvS G9WDDPI+Do/rdlu/8V/pd/IAi1t72HEJVfuIhaJDTD1xqmM1gY6tl2eCE0E/3znv5M9g c8h276ZUYd2HngfdlOxSjDCa3xwE62g5/U4bgckwtv9n6QxVq7KVQSzMrHdau5dB6tuM AAiZ5zaggrdcfa0nCkytUiuBSVO6YRg8QIaC09hkR/HcsK9mIhuHCFcH2xgs5eQkz/qp NlUapo18u2E52sn5oIT+oNzPTvWmbE6v2LRMPqXhFt7wFPt0T/MgHpwYeYnGLKRnGpHh wWKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=G/oXdG+K/mn7k+A9gPyTnR0ScqfyVqdSsawxB342AdQ=; b=FFu16Oz2QOfbN000w/E2vaZjAHTAcm4VjNWEAyVYNjnIM01Yd0i8jGw534Jmhy0h4R ELDbxdHZlv4bjDRX6/O9JjiSvBm8WlLqBaSi53ohxXRj/XYkjzo6iiPwZ0wq8743/JKe MF1s95ryUT5pa8yBjO+0Ap4I6J60fFNXdP004pyDhW0lj+h/elB/I0vvssluuCL7kFVa bx4NOdtb7b83DtiTKIJLQryvYpveXUY5nS1dIMlyazRx7gTTQf4KkAGyZfyGE+JZM+L8 U0hE+occtKQcUR9uf+shlxTLMEFHtlf1g+jRBoGH/jeZe0/qgcn3zNL3kI+vobUiWZHv KXYA== X-Gm-Message-State: AOAM533UK0kMtKOEI3Ij/aAcPXO5820h9eGauPl2IWfIoMRaP1PjWo4Q uBYkS4Kn3r8aa+GuCZtQiUEEZfl2Ah0/YWda9tUklA== X-Google-Smtp-Source: ABdhPJxBcL/69td4pNwnTY44h2Q/U8Jd4y3zpkZWBhgW6XCQnFPyg5FEABOtzjoIl5WK1vJolMvd1YhMDKrOlxqcQgc= X-Received: by 2002:adf:f185:: with SMTP id h5mr13060833wro.302.1631543011063; Mon, 13 Sep 2021 07:23:31 -0700 (PDT) MIME-Version: 1.0 References: <20210913095440.13462-1-peter.maydell@linaro.org> <20210913095440.13462-11-peter.maydell@linaro.org> <0bcbd02d-abb6-de1c-efc3-d0ba465cdb9b@linaro.org> In-Reply-To: <0bcbd02d-abb6-de1c-efc3-d0ba465cdb9b@linaro.org> From: Peter Maydell Date: Mon, 13 Sep 2021 15:22:40 +0100 Message-ID: Subject: Re: [PATCH v2 10/12] target/arm: Optimize MVE VSHLL and VMOVL To: Richard Henderson Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -1 X-Spam_score: -0.2 X-Spam_bar: / X-Spam_report: (-0.2 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 13 Sept 2021 at 15:04, Richard Henderson wrote: > > On 9/13/21 2:54 AM, Peter Maydell wrote: > > Optimize the MVE VSHLL insns by using TCG vector ops when possible. > > This includes the VMOVL insn, which we handle in mve.decode as "VSHLL > > with zero shift count". > > > > Signed-off-by: Peter Maydell > > --- > > The cases here that I've implemented with ANDI then shift > > could also be implemented as shift-then-shift. Is one better > > than another? > > I would expect and + shift to be preferred over shift + shift. OK. (I wasn't sure, because and + shift requires another insn to assemble the immediate constant, I think.) -- PMM