qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Andrew Oates <aoates@google.com>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Michael Roth <mdroth@linux.vnet.ibm.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	"J. Kiszka" <jan.kiszka@siemens.com>
Subject: Re: [Qemu-devel] [PULL 1/1] slirp: fix ICMP handling on macOS hosts
Date: Tue, 14 Aug 2018 16:52:05 +0100	[thread overview]
Message-ID: <CAFEAcA8qK_xGoGfrheganVLUepdGuiheq1UXRu5+iLW5tz=K1Q@mail.gmail.com> (raw)
In-Reply-To: <CAJ1tprBXs6PWP=SsjtPOPNxPJfvWsWFoHCAhovJEGn4=mf8_tw@mail.gmail.com>

On 12 August 2018 at 04:11, Andrew Oates <aoates@google.com> wrote:
> Ping --- would you like me to resubmit the patch using CONFIG_BSD?

Yes, that seems our best option. Could you please also include
a comment that summarises the behaviour of the other host OSes
and why we're using this ifdef?

thanks
-- PMM

  reply	other threads:[~2018-08-14 17:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-29 14:35 [Qemu-devel] [PULL 0/1] slirp fix for qemu 3.0 Samuel Thibault
2018-07-29 14:35 ` [Qemu-devel] [PULL 1/1] slirp: fix ICMP handling on macOS hosts Samuel Thibault
2018-07-30 10:38   ` Peter Maydell
2018-07-31  1:16     ` Andrew Oates
2018-07-31 10:22       ` Peter Maydell
2018-07-31 23:25         ` Andrew Oates
2018-08-01 10:10           ` Peter Maydell
2018-08-01 14:39             ` Andrew Oates
2018-08-12  3:11               ` Andrew Oates
2018-08-14 15:52                 ` Peter Maydell [this message]
2018-08-14 16:01                   ` Andrew Oates

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA8qK_xGoGfrheganVLUepdGuiheq1UXRu5+iLW5tz=K1Q@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=aoates@google.com \
    --cc=jan.kiszka@siemens.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).