* [Qemu-devel] [PATCH] tci: do not include exec/exec-all.h
@ 2016-05-20 11:57 Paolo Bonzini
2016-05-20 14:08 ` Peter Maydell
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2016-05-20 11:57 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell
TCI does not need the runtime definition in exec-all.h. It only needs the
host-side definitions in tcg/tcg.h. Now that cpu.h is not included
everywhere, this caused a failure because exec-all.h does need cpu.h
but does not include it itself.
Fix by including the intended header.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
disas/tci.c | 1 -
tci.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/disas/tci.c b/disas/tci.c
index 7233343..1cdf5ee 100644
--- a/disas/tci.c
+++ b/disas/tci.c
@@ -20,7 +20,6 @@
#include "qemu/osdep.h"
#include "qemu-common.h"
#include "disas/bfd.h"
-#include "exec/exec-all.h"
#include "tcg/tcg.h"
/* Disassemble TCI bytecode. */
diff --git a/tci.c b/tci.c
index 0fdc4e2..b488c0d 100644
--- a/tci.c
+++ b/tci.c
@@ -28,7 +28,7 @@
#endif
#include "qemu-common.h"
-#include "exec/exec-all.h" /* MAX_OPC_PARAM_IARGS */
+#include "tcg/tcg.h" /* MAX_OPC_PARAM_IARGS */
#include "exec/cpu_ldst.h"
#include "tcg-op.h"
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] tci: do not include exec/exec-all.h
2016-05-20 11:57 [Qemu-devel] [PATCH] tci: do not include exec/exec-all.h Paolo Bonzini
@ 2016-05-20 14:08 ` Peter Maydell
0 siblings, 0 replies; 2+ messages in thread
From: Peter Maydell @ 2016-05-20 14:08 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: QEMU Developers
On 20 May 2016 at 12:57, Paolo Bonzini <pbonzini@redhat.com> wrote:
> TCI does not need the runtime definition in exec-all.h. It only needs the
> host-side definitions in tcg/tcg.h. Now that cpu.h is not included
> everywhere, this caused a failure because exec-all.h does need cpu.h
> but does not include it itself.
>
> Fix by including the intended header.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> disas/tci.c | 1 -
> tci.c | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
Applied to master, thanks.
-- PMM
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-20 14:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-20 11:57 [Qemu-devel] [PATCH] tci: do not include exec/exec-all.h Paolo Bonzini
2016-05-20 14:08 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).