qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: Greg Kurz <groug@kaod.org>, Laurent Vivier <lvivier@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] qtest: ask endianness of the target in qtest_init()
Date: Fri, 7 Oct 2016 10:39:09 +0100	[thread overview]
Message-ID: <CAFEAcA8qmxPZNwJ14P8fW005zyntyMkN6yPUuaFVS7qwyWGqRg@mail.gmail.com> (raw)
In-Reply-To: <20161006235529.GI18490@umbus.fritz.box>

On 7 October 2016 at 00:55, David Gibson <david@gibson.dropbear.id.au> wrote:
> It is an improvement.  But I still think if we're relying on the
> ill-defined "target endianness" we're already doing something wrong.

Target endianness is not ill-defined. It's a clear and constant
property of the bus the CPU is plugged into. It is a bit weird
to rely on it in the test code, which is why only the virtio
tests currently use qtest_big_endian().

thanks
-- PMM

  parent reply	other threads:[~2016-10-07  9:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-06 18:56 [Qemu-devel] [PATCH] qtest: ask endianness of the target in qtest_init() Laurent Vivier
2016-10-06 20:45 ` Peter Maydell
2016-10-07  7:10   ` Laurent Vivier
2016-10-07  7:31     ` Greg Kurz
2016-10-07  9:36       ` Peter Maydell
2016-10-07  9:57         ` Greg Kurz
2016-10-06 20:46 ` Greg Kurz
2016-10-06 23:55   ` David Gibson
2016-10-07  7:14     ` Greg Kurz
2016-10-07  9:39     ` Peter Maydell [this message]
2016-10-07 10:10       ` Greg Kurz
2016-10-10  1:30         ` David Gibson
2016-10-10  1:28       ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA8qmxPZNwJ14P8fW005zyntyMkN6yPUuaFVS7qwyWGqRg@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=groug@kaod.org \
    --cc=lvivier@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).