From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59573) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsRcr-0003P6-2t for qemu-devel@nongnu.org; Fri, 07 Oct 2016 05:39:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bsRco-0000l8-P1 for qemu-devel@nongnu.org; Fri, 07 Oct 2016 05:39:31 -0400 Received: from mail-ua0-x236.google.com ([2607:f8b0:400c:c08::236]:33885) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsRco-0000l2-IZ for qemu-devel@nongnu.org; Fri, 07 Oct 2016 05:39:30 -0400 Received: by mail-ua0-x236.google.com with SMTP id p25so40613205uaa.1 for ; Fri, 07 Oct 2016 02:39:30 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20161006235529.GI18490@umbus.fritz.box> References: <1475780218-26393-1-git-send-email-lvivier@redhat.com> <20161006224622.516cee20@bahia> <20161006235529.GI18490@umbus.fritz.box> From: Peter Maydell Date: Fri, 7 Oct 2016 10:39:09 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] qtest: ask endianness of the target in qtest_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: Greg Kurz , Laurent Vivier , QEMU Developers On 7 October 2016 at 00:55, David Gibson wrote: > It is an improvement. But I still think if we're relying on the > ill-defined "target endianness" we're already doing something wrong. Target endianness is not ill-defined. It's a clear and constant property of the bus the CPU is plugged into. It is a bit weird to rely on it in the test code, which is why only the virtio tests currently use qtest_big_endian(). thanks -- PMM