From: Peter Maydell <peter.maydell@linaro.org>
To: Vladimir Sementsov-Ogievskiy <vsementsov@parallels.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] RFC RFC
Date: Wed, 18 Feb 2015 17:37:29 +0900 [thread overview]
Message-ID: <CAFEAcA8qwNM53ZfboimgjnmD8C9Fr3KkpWgeEvyM-FTYpOGKaQ@mail.gmail.com> (raw)
In-Reply-To: <54E4490A.2030706@parallels.com>
On 18 February 2015 at 17:10, Vladimir Sementsov-Ogievskiy
<vsementsov@parallels.com> wrote:
> Can anybody explain what the reasons, politics and consequences of adding
> RFC into patch header in this mailing list? I think, it is not worth to add
> this information to http://wiki.qemu.org/Contribute/SubmitAPatch
"RFC" means "Request For Comments" and is a statement that you don't
intend for your patchset to be applied to master, but would like some
review on it anyway. Reasons for doing this include:
* the patch depends on some pending kernel changes which haven't
yet been accepted, so the QEMU patch series is blocked until that
dependency has been dealt with, but is worth reviewing anyway
* the patch set is not finished yet (perhaps it doesn't cover all
use cases or work with all targets) but you want early review of
a major API change or design structure before continuing
In general, since it's asking other people to do review work
on a patchset that the submitter themselves is saying shouldn't
be applied, it's best to:
* use it sparingly
* in the cover letter, be clear about why a patch is an RFC,
what areas of the patchset you're looking for review on,
and why reviewers should care
-- PMM
next prev parent reply other threads:[~2015-02-18 8:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 8:10 [Qemu-devel] RFC RFC Vladimir Sementsov-Ogievskiy
2015-02-18 8:37 ` Peter Maydell [this message]
2015-02-18 14:01 ` Eric Blake
2015-02-18 14:10 ` Vladimir Sementsov-Ogievskiy
2015-02-18 14:32 ` Max Filippov
2015-02-18 14:54 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8qwNM53ZfboimgjnmD8C9Fr3KkpWgeEvyM-FTYpOGKaQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).