From: Peter Maydell <peter.maydell@linaro.org>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 00/11] Net patches
Date: Thu, 26 Feb 2015 21:15:49 +0900 [thread overview]
Message-ID: <CAFEAcA8qyxbCRig+QRDCJHgBeQg1EoOtk=Qe_u=tEkpePfjx9Q@mail.gmail.com> (raw)
In-Reply-To: <1424702441-5166-1-git-send-email-stefanha@redhat.com>
On 23 February 2015 at 23:40, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> The following changes since commit cd2d5541271f1934345d8ca42f5fafff1744eee7:
>
> Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20150212' into staging (2015-02-13 11:44:50 +0000)
>
> are available in the git repository at:
>
> git://github.com/stefanha/qemu.git tags/net-pull-request
>
> for you to fetch changes up to 9b4e37ada83a0602df60670f4197a97be5c4e74d:
>
> rocker: timestamp on the debug logs helps correlate with events in the VM (2015-02-23 09:47:03 +0000)
Doesn't build on 32 bit, I'm afraid:
CC hw/net/rocker/rocker.o
/root/qemu/hw/net/rocker/rocker.c: In function ?rocker_io_writel?:
/root/qemu/hw/net/rocker/rocker.c:779:21: error: format ?%lx? expects
argument of type ?long unsigned int?, but argument 2 has type ?hwaddr?
[-Werror=format]
/root/qemu/hw/net/rocker/rocker.c:819:9: error: format ?%lx? expects
argument of type ?long unsigned int?, but argument 2 has type ?hwaddr?
[-Werror=format]
/root/qemu/hw/net/rocker/rocker.c: In function ?rocker_io_writeq?:
/root/qemu/hw/net/rocker/rocker.c:839:21: error: format ?%lx? expects
argument of type ?long unsigned int?, but argument 2 has type ?hwaddr?
[-Werror=format]
/root/qemu/hw/net/rocker/rocker.c:839:21: error: format ?%lx? expects
argument of type ?long unsigned int?, but argument 3 has type
?uint64_t? [-Werror=format]
/root/qemu/hw/net/rocker/rocker.c:857:17: error: format ?%lx? expects
argument of type ?long unsigned int?, but argument 2 has type ?hwaddr?
[-Werror=format]
/root/qemu/hw/net/rocker/rocker.c:857:17: error: format ?%lx? expects
argument of type ?long unsigned int?, but argument 3 has type
?uint64_t? [-Werror=format]
/root/qemu/hw/net/rocker/rocker.c: In function ?rocker_mmio_write?:
/root/qemu/hw/net/rocker/rocker.c:949:13: error: format ?%lx? expects
argument of type ?long unsigned int?, but argument 3 has type ?hwaddr?
[-Werror=format]
/root/qemu/hw/net/rocker/rocker.c:949:13: error: format ?%lx? expects
argument of type ?long unsigned int?, but argument 5 has type
?uint64_t? [-Werror=format]
/root/qemu/hw/net/rocker/rocker.c: In function ?rocker_io_readl?:
/root/qemu/hw/net/rocker/rocker.c:1021:21: error: format ?%lx? expects
argument of type ?long unsigned int?, but argument 2 has type ?hwaddr?
[-Werror=format]
/root/qemu/hw/net/rocker/rocker.c:1075:9: error: format ?%lx? expects
argument of type ?long unsigned int?, but argument 2 has type ?hwaddr?
[-Werror=format]
/root/qemu/hw/net/rocker/rocker.c: In function ?rocker_io_readq?:
/root/qemu/hw/net/rocker/rocker.c:1097:21: error: format ?%lx? expects
argument of type ?long unsigned int?, but argument 2 has type ?hwaddr?
[-Werror=format]
/root/qemu/hw/net/rocker/rocker.c:1125:9: error: format ?%lx? expects
argument of type ?long unsigned int?, but argument 2 has type ?hwaddr?
[-Werror=format]
/root/qemu/hw/net/rocker/rocker.c: In function ?rocker_mmio_read?:
/root/qemu/hw/net/rocker/rocker.c:1135:13: error: format ?%lx? expects
argument of type ?long unsigned int?, but argument 3 has type ?hwaddr?
[-Werror=format]
cc1: all warnings being treated as errors
(Apologies for the mangling of smart-quotes into "?" somewhere
along the line.)
Lots of errors in the Windows build too:
In file included from
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker.c:27:
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker.h:22:23:
error: arpa/inet.h: No such file or directory
In file included from
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker.h:24,
from
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker.c:27:
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_world.h:24:
error: redefinition of typedef 'RockerTlv'
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_hw.h:143:
error: previous declaration of 'RockerTlv' was here
In file included from
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker.c:27:
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker.h:71:
error: redefinition of typedef 'World'
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_world.h:22:
error: previous declaration of 'World' was here
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker.h:72:
error: redefinition of typedef 'Rocker'
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_world.h:23:
error: previous declaration of 'Rocker' was here
In file included from
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker.c:29:
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_fp.h:25:
error: redefinition of typedef 'Rocker'
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker.h:72:
error: previous declaration of 'Rocker' was here
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_fp.h:27:
error: redefinition of typedef 'World'
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker.h:71:
error: previous declaration of 'World' was here
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_fp.h:48:
error: expected declaration specifiers or '...' before 'uint'
In file included from
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker.c:30:
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_desc.h:23:
error: redefinition of typedef 'Rocker'
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_fp.h:25:
error: previous declaration of 'Rocker' was here
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_desc.h:25:
error: redefinition of typedef 'DescInfo'
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_world.h:25:
error: previous declaration of 'DescInfo' was here
In file included from
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker.c:33:
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_of_dpa.h:20:
error: redefinition of typedef 'Rocker'
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_desc.h:23:
error: previous declaration of 'Rocker' was here
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_of_dpa.h:21:
error: redefinition of typedef 'World'
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_fp.h:27:
error: previous declaration of 'World' was here
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker.c:68:
error: redefinition of typedef 'Rocker'
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_of_dpa.h:20:
error: previous declaration of 'Rocker' was here
cc1: warnings being treated as errors
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker.c: In
function 'rocker_io_writel':
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker.c:779:
warning: format '%lx' expects type 'long unsigned int', but argument 2
has type 'hwaddr'
/home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker.c:819:
warning: format '%lx' expects type 'long unsigned int', but argument 2
has type 'hwaddr'
(there are more, but I expect most of them are fallout from that attempt
to include arpa/inet.h.)
-- PMM
next prev parent reply other threads:[~2015-02-26 12:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 14:40 [Qemu-devel] [PULL 00/11] Net patches Stefan Hajnoczi
2015-02-23 14:40 ` [Qemu-devel] [PULL 01/11] net: synchronize net_host_device_remove with host_net_remove_completion Stefan Hajnoczi
2015-02-23 14:40 ` [Qemu-devel] [PULL 02/11] tests: rtl8139: test timers and interrupt Stefan Hajnoczi
2015-02-23 14:40 ` [Qemu-devel] [PULL 03/11] net: add MAC address string printer Stefan Hajnoczi
2015-02-23 14:40 ` [Qemu-devel] [PULL 04/11] virtio-net: use qemu_mac_strdup_printf Stefan Hajnoczi
2015-02-23 14:40 ` [Qemu-devel] [PULL 05/11] rocker: add register programming guide Stefan Hajnoczi
2015-02-23 14:40 ` [Qemu-devel] [PULL 06/11] pci: add rocker device ID Stefan Hajnoczi
2015-02-23 14:40 ` [Qemu-devel] [PULL 07/11] pci: add network device class 'other' for network switches Stefan Hajnoczi
2015-02-23 14:40 ` [Qemu-devel] [PULL 08/11] rocker: add new rocker switch device Stefan Hajnoczi
2015-02-23 14:40 ` [Qemu-devel] [PULL 09/11] rocker: add tests Stefan Hajnoczi
2015-02-23 14:40 ` [Qemu-devel] [PULL 10/11] MAINTAINERS: add rocker Stefan Hajnoczi
2015-02-23 14:40 ` [Qemu-devel] [PULL 11/11] rocker: timestamp on the debug logs helps correlate with events in the VM Stefan Hajnoczi
2015-02-26 12:15 ` Peter Maydell [this message]
2015-02-26 17:52 ` [Qemu-devel] [PULL 00/11] Net patches Scott Feldman
2015-02-27 7:20 ` Jiri Pirko
-- strict thread matches above, loose matches on Subject: below --
2014-02-25 13:33 Stefan Hajnoczi
2014-02-26 20:52 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8qyxbCRig+QRDCJHgBeQg1EoOtk=Qe_u=tEkpePfjx9Q@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).