From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6792FECDE27 for ; Wed, 11 Sep 2019 09:14:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2EAF7206A1 for ; Wed, 11 Sep 2019 09:14:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lDchVrXy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2EAF7206A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48438 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7yhs-0006NF-2f for qemu-devel@archiver.kernel.org; Wed, 11 Sep 2019 05:14:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59682) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7y5H-0001F8-RX for qemu-devel@nongnu.org; Wed, 11 Sep 2019 04:34:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i7y5G-00043E-Jr for qemu-devel@nongnu.org; Wed, 11 Sep 2019 04:34:39 -0400 Received: from mail-ot1-x344.google.com ([2607:f8b0:4864:20::344]:42032) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i7y5G-00042n-Db for qemu-devel@nongnu.org; Wed, 11 Sep 2019 04:34:38 -0400 Received: by mail-ot1-x344.google.com with SMTP id c10so21744014otd.9 for ; Wed, 11 Sep 2019 01:34:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CFx8UhCqLcFh5o7ugB22vWUJFtnolgoCeCiFTYWurOU=; b=lDchVrXyjhUsnEeS5L874g3nfcyEXRMij9qCKd2xbyPajf/XsGKObd6erYxaPUPKYP Q4C9RepNA4DJMXCdddfamzW/lvQ/OuQs4OiD1URX7lgHUMNnj6pT/S/Hv/j3VNzkD/Ls 2wLYGrpQ3VSvTrk28HooQAJua3ABQ2kdYttXS2W+CSrGRwZ3AZBHoHS/8/pofNeHB3t/ GyhqgplFadBKsHPeuOaqjK5ZdbNoYlrTYNMGfbLin+G2WGwggxAfYBOLJQDFVNaAItVv 5Sd/xXu/x41vtxLyDibVrCrRcHaiip2qOei6EygtYEiEM61V+sArDwyaLfv3/VCcULj1 bIVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CFx8UhCqLcFh5o7ugB22vWUJFtnolgoCeCiFTYWurOU=; b=S3wASOuKwJu8+F0b98xB92peLTN2JRdAGZTedBvlZoMbAviPXdL8uX/2PnuFEWqs8A 7xAW0EDGS/7D6emdasVwvLgMYNAOg6W3rprdyLiKLutGPqcNnZ3/G/trlV2eu+VMCnWj M75x9+CZ8t4Ejgt+KgpEoeWwO4gFh2k58oqdznnGwJh0tQaXYHg4pglfIQOKvIqvVlLR +chif6xATjd+VKkOdPczYr616a4fUzDWSbg0RjKxmPaneaB6mfzm94kbakGJ+QHcgANj /P8MvIFRrb7SHDpIsgs0GuHCRwdj8nO+eW+U8XfXUuzvOrokZK4x0LpjXQA5Z+eHD521 TLWQ== X-Gm-Message-State: APjAAAVx96BMCKWxhtqpMBVfnq+BGPQ2ph7CyDrFZuSCPl4Q1Jz9Zq5U PbESCLwl/+ckS74b50uGYcYJAife+NgIR8DZEmFkaQ== X-Google-Smtp-Source: APXvYqxbfNh7X/VBvvfmlg9/rKsLiLFKDQ+b+MHwEhYQ6tMFrx+BOrsFH3+W6gK7ho/zYIuUUdJqcW6ITWEZ3Jm02JA= X-Received: by 2002:a9d:5e11:: with SMTP id d17mr7017076oti.135.1568190877452; Wed, 11 Sep 2019 01:34:37 -0700 (PDT) MIME-Version: 1.0 References: <20190911014353.5926-1-richard.henderson@linaro.org> <20190911014353.5926-2-richard.henderson@linaro.org> In-Reply-To: <20190911014353.5926-2-richard.henderson@linaro.org> From: Peter Maydell Date: Wed, 11 Sep 2019 09:34:26 +0100 Message-ID: To: Richard Henderson Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::344 Subject: Re: [Qemu-devel] [PATCH 1/3] cputlb: Disable __always_inline__ without optimization X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tony Nguyen , Mark Cave-Ayland , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 11 Sep 2019 at 02:43, Richard Henderson wrote: > > This forced inlining can result in missing symbols, > which makes a debugging build harder to follow. > > Reported-by: Peter Maydell > Signed-off-by: Richard Henderson > --- > accel/tcg/cputlb.c | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > > diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c > index abae79650c..909f01ebcc 100644 > --- a/accel/tcg/cputlb.c > +++ b/accel/tcg/cputlb.c > @@ -1269,6 +1269,18 @@ static void *atomic_mmu_lookup(CPUArchState *env, target_ulong addr, > cpu_loop_exit_atomic(env_cpu(env), retaddr); > } > > +/* > + * In order for the expected constant folding to happen, > + * we require that some functions be inlined. > + * However, this inlining can make debugging harder for a > + * non-optimizing build. > + */ > +#ifdef __OPTIMIZE__ > +#define ALWAYS_INLINE __attribute__((always_inline)) > +#else > +#define ALWAYS_INLINE > +#endif > + Maybe this should go in compiler.h ? > /* > * Load Helpers > * > @@ -1281,7 +1293,7 @@ static void *atomic_mmu_lookup(CPUArchState *env, target_ulong addr, > typedef uint64_t FullLoadHelper(CPUArchState *env, target_ulong addr, > TCGMemOpIdx oi, uintptr_t retaddr); > > -static inline uint64_t __attribute__((always_inline)) > +static inline uint64_t ALWAYS_INLINE > load_helper(CPUArchState *env, target_ulong addr, TCGMemOpIdx oi, > uintptr_t retaddr, MemOp op, bool code_read, > FullLoadHelper *full_load) > @@ -1530,7 +1542,7 @@ tcg_target_ulong helper_be_ldsl_mmu(CPUArchState *env, target_ulong addr, > * Store Helpers > */ > > -static inline void __attribute__((always_inline)) > +static inline void ALWAYS_INLINE > store_helper(CPUArchState *env, target_ulong addr, uint64_t val, > TCGMemOpIdx oi, uintptr_t retaddr, MemOp op) > { > -- > 2.17.1 Either way Reviewed-by: Peter Maydell thanks -- PMM