From: Peter Maydell <peter.maydell@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com,
qemu-devel@nongnu.org, blauwirbel@gmail.com,
Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] Buildsystem clean tests directory clearly
Date: Fri, 16 Nov 2012 10:29:31 +0000 [thread overview]
Message-ID: <CAFEAcA8s-=v0L8bFNEuk1349wyrckEPUXG29S0mf7T7c93h-OQ@mail.gmail.com> (raw)
In-Reply-To: <50A6143A.4080901@redhat.com>
On 16 November 2012 10:23, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il 16/11/2012 06:05, Wenchao Xia ha scritto:
>> - $(MAKE) -C tests/tcg clean
>> + MAKEFILES=./tests/Makefile $(MAKE) check-clean
>
> What is MAKEFILES?
make uses it as a list of additional makefiles to be read,
as if they were 'include'd at the start of whatever makefile
it actually reads. This is almost certainly not what is
meant here, because this $(MAKE) invocation will reread
the makefile we're currently executing, prepend tests/Makefile
(gratuitously since our Makefile explicitly includes it
anyway) and then invoke the check-clean target, which
happens to work OK because tests/Makefile expects to be
included rather than standalone.
If this roundabout approach is intentional and not accidental
it needs a comment explaining why it's needed.
-- PMM
prev parent reply other threads:[~2012-11-16 10:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 5:05 [Qemu-devel] [PATCH 0/2] Buildsystem fix Wenchao Xia
2012-11-16 5:05 ` [Qemu-devel] [PATCH 1/2] Buildsystem fix distclean error in pixman Wenchao Xia
2012-11-16 9:27 ` Peter Maydell
2012-11-16 10:08 ` Wenchao Xia
2012-11-16 10:16 ` Peter Maydell
2012-11-16 10:27 ` Wenchao Xia
2012-11-16 10:23 ` Paolo Bonzini
2012-11-16 10:26 ` Peter Maydell
2012-11-16 10:38 ` Gerd Hoffmann
2012-11-16 10:53 ` Wenchao Xia
2012-11-16 10:51 ` Wenchao Xia
2012-11-16 5:05 ` [Qemu-devel] [PATCH 2/2] Buildsystem clean tests directory clearly Wenchao Xia
2012-11-16 10:23 ` Paolo Bonzini
2012-11-16 10:29 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8s-=v0L8bFNEuk1349wyrckEPUXG29S0mf7T7c93h-OQ@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).