From: Peter Maydell <peter.maydell@linaro.org>
To: Stefan Weil <weil@mail.berlios.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] Remove unneeded setjmp.h (fix compilation on Debian "lenny")
Date: Mon, 4 Jul 2011 22:02:36 +0100 [thread overview]
Message-ID: <CAFEAcA8s0iJ=LbV0oZmSZF-CfS6_3whNQwBo-_HBS4zDcgBkSA@mail.gmail.com> (raw)
In-Reply-To: <1309805558-13116-1-git-send-email-weil@mail.berlios.de>
On 4 July 2011 19:52, Stefan Weil <weil@mail.berlios.de> wrote:
> Some versions of png.h cannot be included after setjmp.h,
> even when PNG_SKIP_SETJMP_CHECK was defined.
>
> setjmp.h was included from qemu-common.h and is not needed there.
> Removing the include statement fixes compilation of ui/vnc-enc-tight.c
> with CONFIG_VNC_PNG defined.
This isn't the only unnecessary include of setjmp.h, incidentally.
The includes in target-alpha/cpu.h and target-ppc/cpu.h could
also be removed (cpu-defs.h includes setjmp.h). That would also
make those targets consistent with all the rest (which don't include
setjmp), so it seems worth the minor cleanup. I'll send a patch...
-- PMM
next prev parent reply other threads:[~2011-07-04 21:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 0:04 [Qemu-devel] buildbot failure in qemu on disable_kvm_x86_64_debian_5_0 qemu
2011-07-03 23:47 ` Alexander Graf
2011-07-04 4:23 ` Stefan Hajnoczi
2011-07-04 5:41 ` Daniel Gollub
2011-07-04 6:08 ` Stefan Hajnoczi
2011-07-04 5:51 ` Stefan Weil
2011-07-04 9:21 ` Alexander Graf
2011-07-04 16:33 ` Stefan Weil
2011-07-04 18:44 ` [Qemu-devel] [PATCH] Remove unneeded setjmp.h (fix compilation with on Debian "lenny") Stefan Weil
2011-07-04 18:51 ` Stefan Weil
2011-07-04 18:52 ` [Qemu-devel] [PATCH v2] Remove unneeded setjmp.h (fix compilation " Stefan Weil
2011-07-04 21:02 ` Peter Maydell [this message]
2011-07-12 21:28 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8s0iJ=LbV0oZmSZF-CfS6_3whNQwBo-_HBS4zDcgBkSA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).