From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45402) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QdqHx-0000CI-4f for qemu-devel@nongnu.org; Mon, 04 Jul 2011 17:02:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QdqHv-0004IJ-Gv for qemu-devel@nongnu.org; Mon, 04 Jul 2011 17:02:40 -0400 Received: from mail-pz0-f45.google.com ([209.85.210.45]:59655) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QdqHv-0004IA-1w for qemu-devel@nongnu.org; Mon, 04 Jul 2011 17:02:39 -0400 Received: by pzk30 with SMTP id 30so1646013pzk.4 for ; Mon, 04 Jul 2011 14:02:37 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1309805558-13116-1-git-send-email-weil@mail.berlios.de> References: <1309805099-11262-1-git-send-email-weil@mail.berlios.de> <1309805558-13116-1-git-send-email-weil@mail.berlios.de> Date: Mon, 4 Jul 2011 22:02:36 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v2] Remove unneeded setjmp.h (fix compilation on Debian "lenny") List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-devel@nongnu.org On 4 July 2011 19:52, Stefan Weil wrote: > Some versions of png.h cannot be included after setjmp.h, > even when PNG_SKIP_SETJMP_CHECK was defined. > > setjmp.h was included from qemu-common.h and is not needed there. > Removing the include statement fixes compilation of ui/vnc-enc-tight.c > with CONFIG_VNC_PNG defined. This isn't the only unnecessary include of setjmp.h, incidentally. The includes in target-alpha/cpu.h and target-ppc/cpu.h could also be removed (cpu-defs.h includes setjmp.h). That would also make those targets consistent with all the rest (which don't include setjmp), so it seems worth the minor cleanup. I'll send a patch... -- PMM