From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58627) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMyb9-0004ce-S0 for qemu-devel@nongnu.org; Mon, 19 Jun 2017 11:28:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dMyb9-0002g2-7W for qemu-devel@nongnu.org; Mon, 19 Jun 2017 11:28:15 -0400 Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:37429) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dMyb9-0002fY-0w for qemu-devel@nongnu.org; Mon, 19 Jun 2017 11:28:15 -0400 Received: by mail-wm0-x22c.google.com with SMTP id d73so73762587wma.0 for ; Mon, 19 Jun 2017 08:28:14 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20170619144932.GI2640@redhat.com> References: <20170616160658.32290-1-famz@redhat.com> <20170619144932.GI2640@redhat.com> From: Peter Maydell Date: Mon, 19 Jun 2017 16:27:53 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PATCH] migration: Fix race of image locking between src and dst List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Fam Zheng , QEMU Developers , Kevin Wolf , zhanghailiang , Juan Quintela , "Dr. David Alan Gilbert" , Peter Xu , Max Reitz , Stefan Hajnoczi , John Snow On 19 June 2017 at 15:49, Daniel P. Berrange wrote: > IIUC as well as fixing the race condition, you're also improving > error reporting by using qemu_file_set_error() which was not done > previously. Would be nice to mention that in the commit message > too if you respin for any other reason, but that's just a nit-pick I've added N.B. This commit includes a minor improvement to the error handling by using qemu_file_set_error(). to the commit message -- is that OK or do you want to suggest a different wording? thanks -- PMM