From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57740)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Uzpp7-0000H2-8a
	for qemu-devel@nongnu.org; Thu, 18 Jul 2013 11:08:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Uzpp6-0006S8-3q
	for qemu-devel@nongnu.org; Thu, 18 Jul 2013 11:08:53 -0400
Received: from mail-la0-f49.google.com ([209.85.215.49]:47851)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Uzpp5-0006S4-Tz
	for qemu-devel@nongnu.org; Thu, 18 Jul 2013 11:08:52 -0400
Received: by mail-la0-f49.google.com with SMTP id ea20so2560155lab.8
	for <qemu-devel@nongnu.org>; Thu, 18 Jul 2013 08:08:51 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1374159757-16383-4-git-send-email-fred.konrad@greensocs.com>
References: <1374159757-16383-1-git-send-email-fred.konrad@greensocs.com>
	<1374159757-16383-4-git-send-email-fred.konrad@greensocs.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 18 Jul 2013 16:08:30 +0100
Message-ID: <CAFEAcA8sPOm9bFDtwYYL4zH506vp2h6Af=BgBPW8QL_0ZMXc-g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [RFC 3/3] icount: create a new icount based timer.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: fred.konrad@greensocs.com
Cc: pbonzini@redhat.com, mark.burton@greensocs.com, qemu-devel@nongnu.org

On 18 July 2013 16:02,  <fred.konrad@greensocs.com> wrote:
> @@ -156,6 +156,12 @@ void restore_icount(CPUArchState *env, int save)
>  /* Return the virtual CPU time, based on the instruction counter.  */
>  int64_t cpu_get_icount(void)
>  {
> +    return qemu_icount_bias + cpu_get_icount_wo_bias();
> +}
> +
> +/* Return the virtual CPU time, really based on the instruction counter.  */
> +int64_t cpu_get_icount_wo_bias(void)
> +{

The comments for these two functions don't make any sense.
You need to explain what they're actually doing (and
when you'd want one and when the other).

-- PMM