qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Tom Musta <tommusta@gmail.com>
Cc: "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [V2 PATCH 1/2] monitor: QEMU Monitor Instruction Disassembly Incorrect for PowerPC LE Mode
Date: Mon, 7 Apr 2014 22:27:54 +0100	[thread overview]
Message-ID: <CAFEAcA8sX-ERWNzSzUmJHjx5qKLyqzP0pPAPvVTgriSSXk6hMw@mail.gmail.com> (raw)
In-Reply-To: <1396905309-7208-2-git-send-email-tommusta@gmail.com>

On 7 April 2014 22:15, Tom Musta <tommusta@gmail.com> wrote:
>
> +/*
> + * Disassembler for the monitor.  'flags' has the following values:
> + *   i386 - 1 means 16 bit code, 2 means 64 bit code.
> + *   ppc  - bits 0:15 specify (optionally) the machine instruction set;
> + *          bit 16 indicates little endian.
> + *   others - unused
> + */
>  void monitor_disas(Monitor *mon, CPUArchState *env,
>                     target_ulong pc, int nb_insn, int is_physical, int flags)

I think it would be better to (1) fix the target_disas() comment so it
is correct and (2) just say here that the flags word has the same
meaning as for target_disas().

[I should probably fix the ARM monitor_disas flag handling...]

thanks
-- PMM

  reply	other threads:[~2014-04-07 21:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-07 21:15 [Qemu-devel] [V2 PATCH 0/2] QEMU Monitor Instruction Disassembly Incorrect for PPC LE Tom Musta
2014-04-07 21:15 ` [Qemu-devel] [V2 PATCH 1/2] monitor: QEMU Monitor Instruction Disassembly Incorrect for PowerPC LE Mode Tom Musta
2014-04-07 21:27   ` Peter Maydell [this message]
2014-04-07 21:15 ` [Qemu-devel] [V2 PATCH 2/2] target-ppc: Fix target_disas Tom Musta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA8sX-ERWNzSzUmJHjx5qKLyqzP0pPAPvVTgriSSXk6hMw@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=tommusta@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).