qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: QEMU Developers <qemu-devel@nongnu.org>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
	Thomas Huth <thuth@linux.vnet.ibm.com>,
	Patch Tracking <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] configure: check that C++ compiler actually works
Date: Mon, 24 Feb 2014 15:38:31 +0000	[thread overview]
Message-ID: <CAFEAcA8sZszE8zCb8tpf-c7oXrh_yOMOSq_YWwMMReLvwhgJ1g@mail.gmail.com> (raw)
In-Reply-To: <1392909016-14028-1-git-send-email-peter.maydell@linaro.org>

On 20 February 2014 15:10, Peter Maydell <peter.maydell@linaro.org> wrote:
> Check that the C++ compiler works with the C compiler; if it
> does not, then don't pass CXX to the build process. This
> fixes a regression where QEMU was no longer building if the
> build environment didn't have a C++ compiler (introduced
> in commit 3144f78b, which incorrectly assumed that rules.mak
> would only see a non-empty $(CXX) if configure had actually
> found a working C++ compiler).
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> Reported-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> Reported-by: Thomas Huth <thuth@linux.vnet.ibm.com>
> ---
> Apologies for the breakage for people who were building in
> setups with no C++ compiler -- I should have tested the
> original change more thoroughly

Applied directly to master since it's a build-breakage fix.

thanks
-- PMM

      parent reply	other threads:[~2014-02-24 15:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-20 15:10 [Qemu-devel] [PATCH] configure: check that C++ compiler actually works Peter Maydell
2014-02-20 15:58 ` Thomas Huth
2014-02-21  1:43   ` Alexey Kardashevskiy
2014-02-24 15:38 ` Peter Maydell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA8sZszE8zCb8tpf-c7oXrh_yOMOSq_YWwMMReLvwhgJ1g@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=aik@ozlabs.ru \
    --cc=patches@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).