From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48123) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WHxcP-0001W6-TR for qemu-devel@nongnu.org; Mon, 24 Feb 2014 10:39:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WHxcL-0004NN-70 for qemu-devel@nongnu.org; Mon, 24 Feb 2014 10:38:57 -0500 Received: from mail-la0-f49.google.com ([209.85.215.49]:43169) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WHxcL-0004NH-0S for qemu-devel@nongnu.org; Mon, 24 Feb 2014 10:38:53 -0500 Received: by mail-la0-f49.google.com with SMTP id mc6so2408486lab.8 for ; Mon, 24 Feb 2014 07:38:52 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1392909016-14028-1-git-send-email-peter.maydell@linaro.org> References: <1392909016-14028-1-git-send-email-peter.maydell@linaro.org> From: Peter Maydell Date: Mon, 24 Feb 2014 15:38:31 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] configure: check that C++ compiler actually works List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: QEMU Developers Cc: Alexey Kardashevskiy , Thomas Huth , Patch Tracking On 20 February 2014 15:10, Peter Maydell wrote: > Check that the C++ compiler works with the C compiler; if it > does not, then don't pass CXX to the build process. This > fixes a regression where QEMU was no longer building if the > build environment didn't have a C++ compiler (introduced > in commit 3144f78b, which incorrectly assumed that rules.mak > would only see a non-empty $(CXX) if configure had actually > found a working C++ compiler). > > Signed-off-by: Peter Maydell > Reported-by: Alexey Kardashevskiy > Reported-by: Thomas Huth > --- > Apologies for the breakage for people who were building in > setups with no C++ compiler -- I should have tested the > original change more thoroughly Applied directly to master since it's a build-breakage fix. thanks -- PMM