From: Peter Maydell <peter.maydell@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Andrzej Zaborowski <andrew.zaborowski@intel.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] direct usage of rt_clock instead of rtc_clock
Date: Wed, 18 Jan 2012 19:02:40 +0000 [thread overview]
Message-ID: <CAFEAcA8s_m2PHWdqOUvz6LE57vNhiSmxzw3qdssAUdENJh1riw@mail.gmail.com> (raw)
In-Reply-To: <4F1709A5.5080201@redhat.com>
On 18 January 2012 18:04, Paolo Bonzini <pbonzini@redhat.com> wrote:
> the following four files in hw/ are using rt_clock directly
>
> omap1.c
> pxa2xx.c
> strongarm.c
> twl92230.c
>
> instead of rtc_clock. This means that they're not completely deterministic
> when using -icount or in the future qtest. A simple search-and-replace
> would be okay I think. However they could also use a notifier to update the
> timers whenever the rtc_clock jumped backwards (see commit 17604da). If you
> are going to add the notifier I'll happily leave the work to you; otherwise
> I'll post the search-and-replace patch.
I have no strong interest in any of these platforms -- if the simple
search-n-replace you propose works OK and has no particular disadvantages
over the code as it stands that's fine with me.
-- PMM
prev parent reply other threads:[~2012-01-18 19:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-18 18:04 [Qemu-devel] direct usage of rt_clock instead of rtc_clock Paolo Bonzini
2012-01-18 19:02 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8s_m2PHWdqOUvz6LE57vNhiSmxzw3qdssAUdENJh1riw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=andrew.zaborowski@intel.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).