From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43636) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S31MG-0005HP-M9 for qemu-devel@nongnu.org; Thu, 01 Mar 2012 03:27:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S31Lw-0000Zp-GU for qemu-devel@nongnu.org; Thu, 01 Mar 2012 03:27:28 -0500 Received: from mail-pw0-f45.google.com ([209.85.160.45]:37236) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S31Lw-0000Yq-9y for qemu-devel@nongnu.org; Thu, 01 Mar 2012 03:27:08 -0500 Received: by pbcuo1 with SMTP id uo1so715282pbc.4 for ; Thu, 01 Mar 2012 00:27:04 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <4F4F31D2.7010608@suse.de> References: <1330340818-4125-1-git-send-email-e.voevodin@samsung.com> <1330344787-14482-1-git-send-email-e.voevodin@samsung.com> <4F4C4643.2080007@samsung.com> <4F4F31D2.7010608@suse.de> Date: Thu, 1 Mar 2012 08:27:04 +0000 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] TCG: Convert global variables to be TLS. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Andreas_F=C3=A4rber?= Cc: i.mitsyanko@samsung.com, Evgeny Voevodin , qemu-devel@nongnu.org, kyungmin.park@samsung.com, d.solodkiy@samsung.com, m.kozlov@samsung.com On 1 March 2012 08:22, Andreas F=C3=A4rber wrote: > Am 28.02.2012 04:13, schrieb Evgeny Voevodin: >> On 27.02.2012 16:35, Peter Maydell wrote: >>> A true multithreaded TCG is a large project, and unless we're >>> going to commit to doing that I don't see much value in making >>> some variables per-thread when we might instead need to do >>> larger refactorings (properly encapsulating the codegen >>> caches as qom objects, maybe?). >> >> [...] qomification of translation caches is an interesting suggestion I >> think. > > While I have come to like QOM and am using it for the CPUState, I don't > see the benefit in using it for these secondary structures. There are > already dedicated monitor commands to inspect them, no? Mostly I was thinking about the encapsulation of knowing which data structures are associated with a translation cache and letting you have more than one of them. You could do that with a plain struct but since we have this OO infrastructure now why not use it? -- PMM