qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: fred.konrad@greensocs.com
Cc: cornelia.huck@de.ibm.com, aliguori@us.ibm.com,
	mark.burton@greensocs.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 2/7] virtio-serial-pci: switch to the new API.
Date: Wed, 3 Apr 2013 10:25:21 +0100	[thread overview]
Message-ID: <CAFEAcA8sqvHUfnsg_drm+aE==cpLqmpdXoD6sSuDt5oZKsW=gQ@mail.gmail.com> (raw)
In-Reply-To: <1364547764-6627-3-git-send-email-fred.konrad@greensocs.com>

On 29 March 2013 09:02,  <fred.konrad@greensocs.com> wrote:
> -
> -    /* backwards-compatibility with machines that were created with
> -       DEV_NVECTORS_UNSPECIFIED */
> -    vdev->nvectors = proxy->nvectors == DEV_NVECTORS_UNSPECIFIED
> -                                        ? proxy->serial.max_virtserial_ports + 1
> -                                        : proxy->nvectors;

> +
> +    if (vpci_dev->nvectors == DEV_NVECTORS_UNSPECIFIED) {
> +        vpci_dev->nvectors = dev->vdev.serial.max_virtserial_ports + 1;
> +    }
> +

You've lost the clarifying comment in moving this code;
could you add it back please?

thanks
-- PMM

  parent reply	other threads:[~2013-04-03  9:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-29  9:02 [Qemu-devel] [PATCH v4 0/7] virtio-serial refactoring fred.konrad
2013-03-29  9:02 ` [Qemu-devel] [PATCH v4 1/7] virtio-serial: add the virtio-serial device fred.konrad
2013-04-03  6:53   ` Cornelia Huck
2013-04-04 13:54     ` KONRAD Frédéric
2013-03-29  9:02 ` [Qemu-devel] [PATCH v4 2/7] virtio-serial-pci: switch to the new API fred.konrad
2013-04-03  9:18   ` Amit Shah
2013-04-03  9:25   ` Peter Maydell [this message]
2013-03-29  9:02 ` [Qemu-devel] [PATCH v4 3/7] virtio-serial-s390: " fred.konrad
2013-03-29  9:02 ` [Qemu-devel] [PATCH v4 4/7] virtio-serial-ccw: " fred.konrad
2013-03-29  9:02 ` [Qemu-devel] [PATCH v4 5/7] virtio-serial: cleanup: init and exit functions fred.konrad
2013-03-29  9:02 ` [Qemu-devel] [PATCH v4 6/7] virtio-serial: cleanup: use QOM casts fred.konrad
2013-03-29  9:02 ` [Qemu-devel] [PATCH v4 7/7] virtio-serial: cleanup: remove qdev field fred.konrad
2013-04-02 12:03 ` [Qemu-devel] [PATCH v4 0/7] virtio-serial refactoring Peter Maydell
2013-04-02 13:13 ` Anthony Liguori
2013-04-03  6:55 ` Cornelia Huck
2013-04-03  9:27 ` Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA8sqvHUfnsg_drm+aE==cpLqmpdXoD6sSuDt5oZKsW=gQ@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=aliguori@us.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=fred.konrad@greensocs.com \
    --cc=mark.burton@greensocs.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).