From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51078)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1UNJww-0007GS-6b
	for qemu-devel@nongnu.org; Wed, 03 Apr 2013 05:25:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1UNJwt-000617-IN
	for qemu-devel@nongnu.org; Wed, 03 Apr 2013 05:25:46 -0400
Received: from mail-lb0-f180.google.com ([209.85.217.180]:50792)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1UNJwt-00060r-9T
	for qemu-devel@nongnu.org; Wed, 03 Apr 2013 05:25:43 -0400
Received: by mail-lb0-f180.google.com with SMTP id t11so1373353lbi.11
	for <qemu-devel@nongnu.org>; Wed, 03 Apr 2013 02:25:42 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1364547764-6627-3-git-send-email-fred.konrad@greensocs.com>
References: <1364547764-6627-1-git-send-email-fred.konrad@greensocs.com>
	<1364547764-6627-3-git-send-email-fred.konrad@greensocs.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Wed, 3 Apr 2013 10:25:21 +0100
Message-ID: <CAFEAcA8sqvHUfnsg_drm+aE==cpLqmpdXoD6sSuDt5oZKsW=gQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v4 2/7] virtio-serial-pci: switch to the
	new API.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: fred.konrad@greensocs.com
Cc: cornelia.huck@de.ibm.com, aliguori@us.ibm.com, mark.burton@greensocs.com, qemu-devel@nongnu.org

On 29 March 2013 09:02,  <fred.konrad@greensocs.com> wrote:
> -
> -    /* backwards-compatibility with machines that were created with
> -       DEV_NVECTORS_UNSPECIFIED */
> -    vdev->nvectors = proxy->nvectors == DEV_NVECTORS_UNSPECIFIED
> -                                        ? proxy->serial.max_virtserial_ports + 1
> -                                        : proxy->nvectors;

> +
> +    if (vpci_dev->nvectors == DEV_NVECTORS_UNSPECIFIED) {
> +        vpci_dev->nvectors = dev->vdev.serial.max_virtserial_ports + 1;
> +    }
> +

You've lost the clarifying comment in moving this code;
could you add it back please?

thanks
-- PMM