From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=DATE_IN_PAST_03_06, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 125FBC5B578 for ; Mon, 1 Jul 2019 21:13:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE8AF21479 for ; Mon, 1 Jul 2019 21:13:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DMH/Q39r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE8AF21479 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45590 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hi3cU-0003WH-4s for qemu-devel@archiver.kernel.org; Mon, 01 Jul 2019 17:13:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47493) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hi3Iu-0005e4-Kn for qemu-devel@nongnu.org; Mon, 01 Jul 2019 16:53:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hi3Ir-0003iR-IY for qemu-devel@nongnu.org; Mon, 01 Jul 2019 16:53:34 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:36587) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hi3Ir-0003i2-9O for qemu-devel@nongnu.org; Mon, 01 Jul 2019 16:53:33 -0400 Received: by mail-ot1-f65.google.com with SMTP id r6so14922195oti.3 for ; Mon, 01 Jul 2019 13:53:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Po+hiKTXl/WW1dV5JyskiYwMafDOR2b4UMvJ2DcVI6w=; b=DMH/Q39r2kVmR+yR6bIkb3m2K6AsAlftGzdRwC4X0Sqo+rRxhb//JORU1G70gPwXeS Bq+vPI3RxA5PeAxqCjlBJN92op1jcLvFi988TwoqS96uEz79O6IG/Xvk6StrvgtTgEMg dpIvOuu69N/p2QHyIeKc7qYohUQWhIAixAHQyBn7axkjhRzzRuXW3UXzyX0F+hGec+uv r8y1CVEO54GfEGNTSHJ2o8T96HOtDXlAvP2md5cRJ1fi8n9pSDpSTkMkP4zyTRagkBB8 4URLY5qGMb+36LoCWUQCsUk2YZ/iRUrl2Nexq94/xl9wD9MRrbKS9e6amCLPIVjTI0cm v/pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Po+hiKTXl/WW1dV5JyskiYwMafDOR2b4UMvJ2DcVI6w=; b=cA4dBusQjeIrve4qAOaN1dVmdheQ+TYzTMvYkEXpW7+DJ1Q5iEUrT571uJTvdov212 50EBTl5Ck7KmvBay6v+CzU91D8zPG8mrb93MXMQiLKE/zjIczcDyWkaZBi6hv/YmU3iS mrKyNYQ9XiROLXqle2XjLC9MIZnY9yMl8YcD6t/cXXnHnBdDhIvurRsOG6w5tGZYV8OM 5TsisK379/Ovdx79Brpxb/oqf4xT1shMLLO0Ztqq/fJ7IJqdEq9deMLY/cQQf84Hy5fD N17eaKxiJ6tkSZTdnBs5bV662U0SWH/R3ycQY2D68UFaBMzQiB/AvRh4UUllbfIo/FQW DrPA== X-Gm-Message-State: APjAAAUyxbv40uZscMAILsIjyrfXBpZ+/zu7MiQ9cUrPl5khoE2irBav AM17Zm42Y/jfiBmmgALVDs3uzhqm3MW0BHOUzbRSIGJc15g= X-Google-Smtp-Source: APXvYqxA15DfX9/7DbGg+LDBhBbxkNdJNSZN8gzwLSPFJ9qy4sJTdUIKX7wGQBOe9P0AjlbL4CqhCGeygbTPycs32bo= X-Received: by 2002:a9d:7245:: with SMTP id a5mr21350613otk.232.1562000091810; Mon, 01 Jul 2019 09:54:51 -0700 (PDT) MIME-Version: 1.0 References: <20190627152011.18686-1-palmer@sifive.com> <20190627152011.18686-34-palmer@sifive.com> In-Reply-To: <20190627152011.18686-34-palmer@sifive.com> From: Peter Maydell Date: Mon, 1 Jul 2019 17:54:40 +0100 Message-ID: To: Palmer Dabbelt Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.210.65 Subject: Re: [Qemu-devel] [PULL 33/34] roms: Add OpenSBI version 0.3 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alistair Francis , Bin Meng , "open list:RISC-V" , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 27 Jun 2019 at 16:24, Palmer Dabbelt wrote: > > From: Alistair Francis > > Add OpenSBI version 0.3 as a git submodule and as a prebult binary. > > Signed-off-by: Alistair Francis > Reviewed-by: Bin Meng > Tested-by: Bin Meng > Signed-off-by: Palmer Dabbelt > --- > .gitmodules | 3 ++ > Makefile | 5 +- > pc-bios/opensbi-riscv32-virt-fw_jump.bin | Bin 0 -> 28848 bytes > pc-bios/opensbi-riscv64-sifive_u-fw_jump.bin | Bin 0 -> 28904 bytes > pc-bios/opensbi-riscv64-virt-fw_jump.bin | Bin 0 -> 28904 bytes > roms/Makefile | 48 ++++++++++++++----- > roms/opensbi | 1 + > 7 files changed, 44 insertions(+), 13 deletions(-) > create mode 100644 pc-bios/opensbi-riscv32-virt-fw_jump.bin > create mode 100644 pc-bios/opensbi-riscv64-sifive_u-fw_jump.bin > create mode 100644 pc-bios/opensbi-riscv64-virt-fw_jump.bin > create mode 160000 roms/opensbi > > diff --git a/.gitmodules b/.gitmodules > index 2857eec76377..7a10e72e09cd 100644 > --- a/.gitmodules > +++ b/.gitmodules > @@ -55,3 +55,6 @@ > [submodule "slirp"] > path = slirp > url = https://git.qemu.org/git/libslirp.git > +[submodule "roms/opensbi"] > + path = roms/opensbi > + url = https://github.com/riscv/opensbi.git It would be nice to state the license for new blobs we're adding to the source tree... In particular, I find the readme at https://github.com/riscv/opensbi a bit confusing because it says it's 2-BSD but also that some parts are Apache-2.0; the latter is *not* GPL-2.0 compatible. That makes it not completely obvious to me that we can ship this with QEMU. Also, new git modules in .gitmodules should be qemu.org URLs, not random external ones. (ie, we should set up mirroring of any new external repo we start shipping code and binaries for). We can set this up and fix up the gitmodules file after the fact, but the ideal is to do it in advance rather than afterwards. thanks -- PMM