From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXPQt-0001yA-AB for qemu-devel@nongnu.org; Thu, 13 Dec 2018 06:45:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXPQs-0000XR-Nu for qemu-devel@nongnu.org; Thu, 13 Dec 2018 06:45:35 -0500 Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]:43945) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gXPQs-0000X6-IT for qemu-devel@nongnu.org; Thu, 13 Dec 2018 06:45:34 -0500 Received: by mail-oi1-x243.google.com with SMTP id u18so1352871oie.10 for ; Thu, 13 Dec 2018 03:45:34 -0800 (PST) MIME-Version: 1.0 References: <1544701071-2922-1-git-send-email-liq3ea@gmail.com> In-Reply-To: <1544701071-2922-1-git-send-email-liq3ea@gmail.com> From: Peter Maydell Date: Thu, 13 Dec 2018 11:45:22 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PATCH v2] util: check the return value of fcntl in qemu_set_{block, nonblock} List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Li Qiang Cc: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Paolo Bonzini , "Daniel P. Berrange" , QEMU Developers On Thu, 13 Dec 2018 at 11:37, Li Qiang wrote: > > Also add diagnostics info in 'qemu_set_cloexec' so that we can know > what happen when error occurs. > > Signed-off-by: Li Qiang > --- > Change since v1: add diagnostics info We need to fix the assert in the test suite first... thanks -- PMM