From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58819)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1XhHAp-0007Tj-Vd
	for qemu-devel@nongnu.org; Thu, 23 Oct 2014 08:08:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1XhHAF-0005w7-LC
	for qemu-devel@nongnu.org; Thu, 23 Oct 2014 08:07:23 -0400
Received: from mail-lb0-f174.google.com ([209.85.217.174]:49849)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1XhHAF-0005te-36
	for qemu-devel@nongnu.org; Thu, 23 Oct 2014 08:06:47 -0400
Received: by mail-lb0-f174.google.com with SMTP id p9so689084lbv.5
	for <qemu-devel@nongnu.org>; Thu, 23 Oct 2014 05:06:46 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1414065329-7357-1-git-send-email-riku.voipio@linaro.org>
References: <1414065329-7357-1-git-send-email-riku.voipio@linaro.org>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 23 Oct 2014 13:06:25 +0100
Message-ID: <CAFEAcA8uDvuORyJ-NdR_SYRkF9PX4D4o=4-S_8fZmdCbkb9pSA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] linux-user: Fix fault address truncation
	AArch64
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Riku Voipio <riku.voipio@linaro.org>
Cc: Claudio Fontana <claudio.fontana@huawei.com>, Amanieu <amanieu@gmail.com>, QEMU Developers <qemu-devel@nongnu.org>

On 23 October 2014 12:55,  <riku.voipio@linaro.org> wrote:
> From: Riku Voipio <riku.voipio@linaro.org>
>
> On AArch64 the si_addr field of siginfo_t is truncated to 32 bits
> because the fault address passes through an uint32_t variable. This
> is fixed by changing the variable to uint64_t.
>
> v2 by Riku - follow Peters suggestion and drop the addr variable
> since its only used once in the Aarch64 loop.
>
> Reported-by: Amanieu d'Antras <amanieu@gmail.com>
> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>

Ah, I was just wondering this morning whether I ought
to do a version of this patch, so you've saved me the effort :-)

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

(You might want to put the notes about v2 below the '---'.)

thanks
-- PMM