From: Peter Maydell <peter.maydell@linaro.org>
To: Markus Armbruster <armbru@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
fam@euphon.net, Paolo Bonzini <pbonzini@redhat.com>,
coli@redhat.com, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-3.1] vfio-helpers: Fix qemu_vfio_open_pci() crash
Date: Tue, 27 Nov 2018 20:59:48 +0000 [thread overview]
Message-ID: <CAFEAcA8unXASA_hqZpqT12Ruv31ySnXakuBSVrEc7GTLFcPLYA@mail.gmail.com> (raw)
In-Reply-To: <20181127084143.1113-1-armbru@redhat.com>
On Tue, 27 Nov 2018 at 08:42, Markus Armbruster <armbru@redhat.com> wrote:
>
> qemu_vfio_open_common() initializes s->lock only after passing s to
> qemu_vfio_dma_map() via qemu_vfio_init_ramblock().
> qemu_vfio_dma_map() tries to lock the uninitialized lock and crashes.
>
> Fix by initializing s->lock first.
>
> RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1645840
> Fixes: 418026ca43bc2626db092d7558258f9594366f28
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> Compile-tested only, as I lack suitable hardware. Cong Li (cc'ed) is
> going to test it for real. It looks obvious enough to me to put it
> into -rc3 without waiting for the test results. We can also wait and
> put it into -rc4.
>
> util/vfio-helpers.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks (for rc3).
-- PMM
next prev parent reply other threads:[~2018-11-27 21:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 8:41 [Qemu-devel] [PATCH for-3.1] vfio-helpers: Fix qemu_vfio_open_pci() crash Markus Armbruster
2018-11-27 9:04 ` Cornelia Huck
2018-11-27 9:18 ` Stefan Hajnoczi
2018-11-27 20:59 ` Peter Maydell [this message]
2018-11-28 5:47 ` Cong Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8unXASA_hqZpqT12Ruv31ySnXakuBSVrEc7GTLFcPLYA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=armbru@redhat.com \
--cc=coli@redhat.com \
--cc=fam@euphon.net \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).