From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org,
"Richard Henderson" <richard.henderson@linaro.org>,
"Dapeng Mi" <dapeng1.mi@intel.com>,
"Sean Christopherson" <seanjc@google.com>,
"Bin Meng" <bin.meng@windriver.com>,
"Zhuocheng Ding" <zhuocheng.ding@intel.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Zhenyu Wang" <zhenyu.z.wang@intel.com>,
qemu-riscv@nongnu.org,
"Alistair Francis" <alistair.francis@wdc.com>,
"Zhao Liu" <zhao1.liu@intel.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Robert Hoo" <robert.hu@linux.intel.com>,
"Yanan Wang" <wangyanan55@huawei.com>,
qemu-arm@nongnu.org, "Palmer Dabbelt" <palmer@dabbelt.com>,
"Like Xu" <like.xu.linux@gmail.com>,
"Alistair Francis" <alistair@alistair23.me>,
"Zhao Liu" <zhao1.liu@linux.intel.com>,
"Eduardo Habkost" <eduardo@habkost.net>
Subject: Re: [PATCH 2/5] hw/cpu/cluster: Only add CPU objects to CPU cluster
Date: Tue, 21 Feb 2023 17:56:20 +0000 [thread overview]
Message-ID: <CAFEAcA8v1q-OVoyZG14eDWL1_je=mzxk2U56mJ__P-eb2oAGJg@mail.gmail.com> (raw)
In-Reply-To: <20230216142338.82982-3-philmd@linaro.org>
On Thu, 16 Feb 2023 at 14:23, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Do not recursively add CPU and all their children objects.
> Simply iterate on the cluster direct children, which must
> be of TYPE_CPU. Otherwise raise an error.
The documentation in include/hw/cpu/cluster.h says:
* The CPUs may be either direct children of the cluster object, or indirect
* children (e.g. children of children of the cluster object).
If we want to change that we need to update the documentation too.
I'm not sure why this doesn't hit the error on the armsse.c
use of TYPE_CLUSTER -- there the objects we have to put in
the cluster are TYPE_ARMV7M, which are not themselves
TYPE_CPU. They're a container which contains a TYPE_CPU.
This is why the docs say that it's OK to have the CPU
be an indirect child. I think one of the riscv boards
may be also using this facility, but I'm less sure there.
thanks
-- PMM
next prev parent reply other threads:[~2023-02-21 17:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 14:23 [PATCH 0/5] hw/cpu/cluster: Restrict CPU cluster to a particular CPU type Philippe Mathieu-Daudé
2023-02-16 14:23 ` [PATCH 1/5] hw/cpu: Extend CPUState::cluster_index documentation Philippe Mathieu-Daudé
2023-02-21 17:47 ` Peter Maydell
2023-02-16 14:23 ` [PATCH 2/5] hw/cpu/cluster: Only add CPU objects to CPU cluster Philippe Mathieu-Daudé
2023-02-21 17:56 ` Peter Maydell [this message]
2023-02-16 14:23 ` [PATCH 3/5] hw/cpu/cluster: Restrict CPU cluster to a particular CPU type Philippe Mathieu-Daudé
2023-02-21 17:59 ` Peter Maydell
2023-02-16 14:23 ` [PATCH 4/5] hw/arm: Restrict CPU clusters to the expected type Philippe Mathieu-Daudé
2023-02-16 14:23 ` [PATCH 5/5] hw/riscv: " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8v1q-OVoyZG14eDWL1_je=mzxk2U56mJ__P-eb2oAGJg@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=alistair@alistair23.me \
--cc=bin.meng@windriver.com \
--cc=dapeng1.mi@intel.com \
--cc=edgar.iglesias@gmail.com \
--cc=eduardo@habkost.net \
--cc=like.xu.linux@gmail.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=robert.hu@linux.intel.com \
--cc=seanjc@google.com \
--cc=wangyanan55@huawei.com \
--cc=zhao1.liu@intel.com \
--cc=zhao1.liu@linux.intel.com \
--cc=zhenyu.z.wang@intel.com \
--cc=zhuocheng.ding@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).