From: Peter Maydell <peter.maydell@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] integrator: fix Linux boot failure by emulating dbg
Date: Thu, 17 Oct 2013 17:16:24 +0100 [thread overview]
Message-ID: <CAFEAcA8v5ysTEmhzCcM2kw-zpc0dJ3AqbofN_3YeENakCNt2Yw@mail.gmail.com> (raw)
In-Reply-To: <1382026334-8418-2-git-send-email-alex.bennee@linaro.org>
On 17 October 2013 17:12, Alex Bennée <alex.bennee@linaro.org> wrote:
> From: Alex Bennée <alex@bennee.com>
>
> Commit 9b8c69243 broke the ability to boot the kernel as the value
> returned by unassigned_mem_read returned non-zero and left the kernel
> looping forever waiting for it to change (see integrator_led_set in
> the kernel code).
>
> Relying on a varying implementation detail is incorrect anyway so this
> introduces a memory region to emulate the debug/led region on the
> integrator board. It is currently a basic stub as I have no idea what the
> behaviour of this region should be so for now it simply returns 0's as
> the old unassigned_mem_read did.
Commit message, comment, overlength lines, lack of Copyright line
still all unfixed : did you resend the wrong version?
thanks
-- PMM
next prev parent reply other threads:[~2013-10-17 16:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-17 16:12 [Qemu-devel] [RESEND PULL v5 0/0] .travis.yml: basic compile and check recipies Alex Bennée
2013-10-17 16:12 ` [Qemu-devel] [PATCH] integrator: fix Linux boot failure by emulating dbg Alex Bennée
2013-10-17 16:16 ` Peter Maydell [this message]
2013-10-17 16:59 ` Alex Bennée
-- strict thread matches above, loose matches on Subject: below --
2013-09-13 14:58 alex.bennee
2013-09-13 15:20 ` Peter Maydell
2013-09-13 17:39 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8v5ysTEmhzCcM2kw-zpc0dJ3AqbofN_3YeENakCNt2Yw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).