From: Peter Maydell <peter.maydell@linaro.org>
To: liguang <lig.fnst@cn.fujitsu.com>
Cc: ehabkost@redhat.com, jan.kiszka@siemens.com,
qemu-devel@nongnu.org, blauwirbel@gmail.com, imammedo@redhat.com,
afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function
Date: Thu, 6 Dec 2012 08:54:44 +0000 [thread overview]
Message-ID: <CAFEAcA8v_sDfOVRLHbeHuGSaPtE1E5XMkcivGf6CSmEFjcWZ2w@mail.gmail.com> (raw)
In-Reply-To: <1354762999-4135-3-git-send-email-lig.fnst@cn.fujitsu.com>
On 6 December 2012 03:03, liguang <lig.fnst@cn.fujitsu.com> wrote:
> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> --- a/target-i386/seg_helper.c
> +++ b/target-i386/seg_helper.c
> @@ -465,9 +465,9 @@ static void switch_tss(CPUX86State *env, int tss_selector,
>
> #ifndef CONFIG_USER_ONLY
> /* reset local breakpoints */
> - if (env->dr[7] & 0x55) {
> - for (i = 0; i < 4; i++) {
> - if (hw_breakpoint_enabled(env->dr[7], i) == 0x1) {
> + if (env->dr[7] & DR7_LOCAL_BP_MASK) {
> + for (i = 0; i < DR7_MAX_BP; i++) {
> + if (hw_breakpoint_enabled(env->dr[7], i)) {
> hw_breakpoint_remove(env, i);
> }
> }
This is still wrong.
PS: if you could put the 'v2'/'v3' etc marking in the [PATCH]
tags for the subjects of all the patch emails and not just the
cover letter that would be helpful. git format-patch's
--subject-prefix='PATCH v3' option should do this for you.
-- PMM
next prev parent reply other threads:[~2012-12-06 8:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 3:03 [Qemu-devel] [PATCH 1/3] target-i386:define name of breakpoint bit in dr7 liguang
2012-12-06 3:03 ` [Qemu-devel] [PATCH 2/3] target-i386:make hw_breakpoint_enabled return bool type liguang
2012-12-06 3:03 ` [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function liguang
2012-12-06 8:54 ` Peter Maydell [this message]
2012-12-06 9:16 ` li guang
2012-12-06 9:23 ` Peter Maydell
2012-12-06 9:27 ` li guang
2012-12-06 9:35 ` 陳韋任 (Wei-Ren Chen)
2012-12-06 9:36 ` Andreas Färber
2012-12-06 9:48 ` Peter Maydell
2012-12-06 9:57 ` Andreas Färber
2012-12-07 0:53 ` li guang
2012-12-06 9:44 ` Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2012-12-04 8:11 [Qemu-devel] [PATCH 1/3] target-i386:define name of breakpoint bit in dr7 liguang
2012-12-04 8:11 ` [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function liguang
2012-12-04 18:51 ` Blue Swirl
2012-12-05 0:56 ` li guang
2012-12-05 8:55 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8v_sDfOVRLHbeHuGSaPtE1E5XMkcivGf6CSmEFjcWZ2w@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=afaerber@suse.de \
--cc=blauwirbel@gmail.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=lig.fnst@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).