From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47574) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dk4qp-0001V1-Sn for qemu-devel@nongnu.org; Tue, 22 Aug 2017 04:47:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dk4qp-0003YC-4N for qemu-devel@nongnu.org; Tue, 22 Aug 2017 04:47:55 -0400 Received: from mail-wr0-x22c.google.com ([2a00:1450:400c:c0c::22c]:36482) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dk4qo-0003Xk-UW for qemu-devel@nongnu.org; Tue, 22 Aug 2017 04:47:55 -0400 Received: by mail-wr0-x22c.google.com with SMTP id f8so82861985wrf.3 for ; Tue, 22 Aug 2017 01:47:54 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20170822010917.GO12356@umbus.fritz.box> References: <20170816082650.21880-1-cohuck@redhat.com> <223c4e3c-097f-5a91-37fa-df4bfb427d60@redhat.com> <20170822010917.GO12356@umbus.fritz.box> From: Peter Maydell Date: Tue, 22 Aug 2017 09:47:33 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PATCH for-2.10] boot-serial-test: prefer tcg accelerator List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: Paolo Bonzini , Laurent Vivier , Thomas Huth , "Michael S. Tsirkin" , Cornelia Huck , Richard Henderson , QEMU Developers On 22 August 2017 at 02:09, David Gibson wrote: > On Wed, Aug 16, 2017 at 12:18:07PM +0100, Peter Maydell wrote: >> On 16 August 2017 at 11:51, Paolo Bonzini wrote: >> > On 16/08/2017 10:26, Cornelia Huck wrote: >> >> Prefer to use the tcg accelarator if it is available: This is our only >> >> real smoke test for tcg, and fast enough to use it for that. >> > >> > I'm not sure this is required for 2.10. Yes, it means the coverage from >> > "make check" is worse, but that's it. >> >> Yes, I'd put it under "if we need to roll an rc4 anyway for >> some more significant bug we might as well put this in too, >> but it doesn't merit cutting rc4 by itself." > > It does entirely break "make check" on a ppc host. And that in turn > has held up my testing cycle for a couple of ppc regressions from 2.9 > that I was hoping to squeeze in. Does that change your calculations? I have a PPC64 box in my standard set of build tests, and it runs 'make check' without problems... thanks -- PMM