From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43930)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Z835I-0005G0-Bu
	for qemu-devel@nongnu.org; Thu, 25 Jun 2015 05:04:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Z835F-0005G9-LF
	for qemu-devel@nongnu.org; Thu, 25 Jun 2015 05:04:36 -0400
Received: from mail-vn0-f46.google.com ([209.85.216.46]:44483)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Z835F-0005Fv-HT
	for qemu-devel@nongnu.org; Thu, 25 Jun 2015 05:04:33 -0400
Received: by vnbg7 with SMTP id g7so10054813vnb.11
	for <qemu-devel@nongnu.org>; Thu, 25 Jun 2015 02:04:33 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <878ub844of.fsf@blackfin.pond.sub.org>
References: <1435068107-12594-1-git-send-email-peter.maydell@linaro.org>
	<1435068107-12594-4-git-send-email-peter.maydell@linaro.org>
	<878ub844of.fsf@blackfin.pond.sub.org>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 25 Jun 2015 10:04:13 +0100
Message-ID: <CAFEAcA8wiZGcxT=-Fjaz1WSdXprSRyATqJOj8ZUD9o6xpUtVyQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v2 for-2.4 3/3] hw/arm/virt: Make block
 devices default to virtio
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, qemu-block@nongnu.org, Patch Tracking <patches@linaro.org>

On 25 June 2015 at 08:40, Markus Armbruster <armbru@redhat.com> wrote:
> Peter Maydell <peter.maydell@linaro.org> writes:
>
>> Now we have virtio-pci, we can make the virt board's default block
>> device type be IF_VIRTIO. This allows users to use simplified
>> command lines that don't have to explicitly create virtio-pci-blk
>> devices; the -hda &c very short options now also work.
>>
>> This means we also need to set no_cdrom to avoid getting a
>> default cdrom device -- this is needed because the virtio-blk
>> device will fail if it is connected to a block backend with
>> no media, which is what the default cdrom device typically is.
>> Providing a cdrom with media via -cdrom will still work.
>
> It'll create a virtio-blk device with non-removable medium, won't it?

Yes, I think so. Mostly I cared that -cdrom won't make qemu die with a
confusing error.

(Without no_cdrom, qemu dies even if you don't say -cdrom, because
of the default empty drive.)

>> The command line will be changed to include 'if=none', as the
>
> will have to be changed

Yes.

-- PMM