From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CE0BC433ED for ; Thu, 13 May 2021 10:50:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 970DE6142C for ; Thu, 13 May 2021 10:50:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 970DE6142C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49254 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lh8vH-0004K8-HE for qemu-devel@archiver.kernel.org; Thu, 13 May 2021 06:50:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39076) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lh8tS-0001xB-3m for qemu-devel@nongnu.org; Thu, 13 May 2021 06:48:38 -0400 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:33475) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lh8tQ-0003Yq-HF for qemu-devel@nongnu.org; Thu, 13 May 2021 06:48:37 -0400 Received: by mail-ed1-x52f.google.com with SMTP id b17so30483280ede.0 for ; Thu, 13 May 2021 03:48:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WYNR3E5xBld5+hYWcPBTYDEgz2OvbmhDiBBg0vbQWXI=; b=WlFz3+6JoNgUbKeeBD25emxw1cr4qo9tDKmJROtUkDOlj0hqnCU9EL3cg9ukcSLOD3 3Jd0gUJd0e5lTazoAaZm+TfQJLztEYCjhIIRWP1Az/9DUAcDYQWqASAnEe+jnK12llyR +OMiIMFRArd7hrwNzbPAd5JQAgu+eM+rLk6ar3DjqYYMy0CaZlGjaO0/RcN7T0gwYF9z vVJtvjUT1duYJYoHRXLx/fywLhEPluh8IvOzyGoqcobwHJjD+VXJwXJiR5QPpTGnowON cX3isIURRvT6XSMGKsMG1LbabnyQSFC1Hlii+4eXZb2JhCm9q4VACce8HfjD+nWu/zSq pgZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WYNR3E5xBld5+hYWcPBTYDEgz2OvbmhDiBBg0vbQWXI=; b=YFz7QnVgICwADuAevFhnZtQ7zF6C70IlaZ3/+c0Lfqb7gdE5ioDLjqaPEf7AQuhm7G tBO2GRoCNKYGo7DwK71SagZ/savrGLks9MnULXxdU92crsAlyheRcksU/YxfkwAAS/9N pThNvijZPVwHfdYJ/MOafAREeeOlf/Jt2O/RSKjkEPeydbT0QaDjTHEgktjuTJ+PMQ+8 DiM5NQpfOpOjku+gPRqjoUSlgpFaXxALONCwOT5T3U42QzdfoyEdrewTO/qZ7SHG7XH9 4pbpuP6oKQk1uYG5R5ydPitskv+Ch/3gN5j9Ivc75Z06OBmrStu4r27WcSwp61moilK9 Lmyw== X-Gm-Message-State: AOAM532yqEE349LnYxCn+5Y7rB2kP7omqTSxDST1qxuxVmgQW/XgF3Ft Csej44Bz0RPEIOP6kqFW7vhlTRu5N/iZFAxn9fAPOw== X-Google-Smtp-Source: ABdhPJxq3QCCAz0i6KeyASiHnLd6ADrYGIp7R0asxIoQtep1B2/IepFyNMWW1LiAEW2gNPOnkyjyxqh78v8L5Q1QhGY= X-Received: by 2002:a05:6402:3548:: with SMTP id f8mr48883461edd.251.1620902914960; Thu, 13 May 2021 03:48:34 -0700 (PDT) MIME-Version: 1.0 References: <20210416210240.1591291-1-richard.henderson@linaro.org> <20210416210240.1591291-50-richard.henderson@linaro.org> In-Reply-To: <20210416210240.1591291-50-richard.henderson@linaro.org> From: Peter Maydell Date: Thu, 13 May 2021 11:48:23 +0100 Message-ID: Subject: Re: [PATCH v5 49/81] target/arm: Pass separate addend to FCMLA helpers To: Richard Henderson Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::52f; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 16 Apr 2021 at 22:58, Richard Henderson wrote: > > For SVE, we potentially have a 4th argument coming from the > movprfx instruction. Currently we do not optimize movprfx, > so the problem is not visible. > > Signed-off-by: Richard Henderson > --- > target/arm/helper.h | 20 ++++++------- > target/arm/translate-a64.c | 28 ++++++++++++++---- > target/arm/translate-sve.c | 5 ++-- > target/arm/vec_helper.c | 50 +++++++++++++-------------------- > target/arm/translate-neon.c.inc | 10 ++++--- > 5 files changed, 62 insertions(+), 51 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM