From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38533)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VK2k0-00048Z-PR
	for qemu-devel@nongnu.org; Thu, 12 Sep 2013 04:59:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VK2jw-0007Pi-10
	for qemu-devel@nongnu.org; Thu, 12 Sep 2013 04:59:08 -0400
Received: from mail-lb0-f181.google.com ([209.85.217.181]:46648)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VK2jv-0007Pd-QW
	for qemu-devel@nongnu.org; Thu, 12 Sep 2013 04:59:03 -0400
Received: by mail-lb0-f181.google.com with SMTP id u14so592842lbd.26
	for <qemu-devel@nongnu.org>; Thu, 12 Sep 2013 01:59:02 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <52317A6C.20400@huawei.com>
References: <1378144503-15808-1-git-send-email-rth@twiddle.net>
	<1378144503-15808-2-git-send-email-rth@twiddle.net>
	<52317A6C.20400@huawei.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 12 Sep 2013 09:58:41 +0100
Message-ID: <CAFEAcA8wn5xE8rdizvGjhJ6musCFCPS0DDYEKtc8GcdYPgCDAA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v3 01/29] tcg-aarch64: Set ext based on
	TCG_OPF_64BIT
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Claudio Fontana <claudio.fontana@huawei.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Richard Henderson <rth@twiddle.net>

On 12 September 2013 09:25, Claudio Fontana <claudio.fontana@huawei.com> wrote:
> On 02.09.2013 19:54, Richard Henderson wrote:
>>
>> -    case INDEX_op_bswap64_i64:
>> -        ext = 1; /* fall through */
>>      case INDEX_op_bswap32_i64:
>> +        /* Despite the _i64, this is a 32-bit bswap.  */
>> +        ext = 0;
>> +        /* FALLTHRU */
>> +    case INDEX_op_bswap64_i64:
>
> we waste too much y space here, which gives context and is a scarse resource.
> What about
>
> case INDEX_op_bswap32_i64: /* Despite the _i64, this is a 32-bit bswap.  */
>     ext = false; /* FALLTHRU */

Consensus in the rest of the code is for /* fall through */
rather than /* FALLTHRU */ -- there's only 28 of the
latter compared to 169 of the former.

-- PMM