From: Peter Maydell <peter.maydell@linaro.org>
To: Hao Wu <wuhaotsh@google.com>
Cc: Qemu-block <qemu-block@nongnu.org>,
"Patrick Venture" <venture@google.com>,
"Bin Meng" <bin.meng@windriver.com>,
"Havard Skinnemoen" <hskinnemoen@google.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"CS20 KFTing" <kfting@nuvoton.com>,
qemu-arm <qemu-arm@nongnu.org>,
"IS20 Avi Fishman" <Avi.Fishman@nuvoton.com>,
"Chris Rauer" <crauer@google.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [PATCH 1/4] tests/qtest/libqos: add SDHCI commands
Date: Mon, 13 Sep 2021 15:48:39 +0100 [thread overview]
Message-ID: <CAFEAcA8x+djYN7-+fW6CLTRDP+WhjdvsQF4pdMRiSmnjofezLQ@mail.gmail.com> (raw)
In-Reply-To: <20210907232555.3268967-2-wuhaotsh@google.com>
On Wed, 8 Sept 2021 at 00:26, Hao Wu <wuhaotsh@google.com> wrote:
>
> From: Shengtan Mao <stmao@google.com>
>
> Signed-off-by: Shengtan Mao <stmao@google.com>
> Reviewed-by: Hao Wu <wuhaotsh@google.com>
> Reviewed-by: Chris Rauer <crauer@google.com>
> Reviewed-by: Tyrone Ting <kfting@nuvoton.com>
I think this patch would make more sense placed later in the
series, just before the current patch 4 which is the user
of the functions added here.
-- PMM
next prev parent reply other threads:[~2021-09-13 14:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 23:25 [PATCH 0/4] hw/arm: Add MMC device for NPCM7XX boards Hao Wu
2021-09-07 23:25 ` [PATCH 1/4] tests/qtest/libqos: add SDHCI commands Hao Wu
2021-09-13 14:48 ` Peter Maydell [this message]
2021-09-07 23:25 ` [PATCH 2/4] hw/sd: add nuvoton MMC Hao Wu
2021-09-13 14:16 ` Peter Maydell
2021-09-07 23:25 ` [PATCH 3/4] hw/arm: Attach MMC to quanta-gbs-bmc Hao Wu
2021-09-13 14:40 ` Peter Maydell
2021-09-07 23:25 ` [PATCH 4/4] tests/qtest: add qtests for npcm7xx sdhci Hao Wu
2021-09-13 14:47 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8x+djYN7-+fW6CLTRDP+WhjdvsQF4pdMRiSmnjofezLQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=Avi.Fishman@nuvoton.com \
--cc=bin.meng@windriver.com \
--cc=crauer@google.com \
--cc=f4bug@amsat.org \
--cc=hskinnemoen@google.com \
--cc=kfting@nuvoton.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=venture@google.com \
--cc=wuhaotsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).