From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56119) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCnEK-0007vK-La for qemu-devel@nongnu.org; Wed, 08 Jul 2015 07:09:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCnEH-0005Ct-W3 for qemu-devel@nongnu.org; Wed, 08 Jul 2015 07:09:32 -0400 Received: from mail-vn0-f46.google.com ([209.85.216.46]:35767) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCnEH-0005CW-Rj for qemu-devel@nongnu.org; Wed, 08 Jul 2015 07:09:29 -0400 Received: by vnbg190 with SMTP id g190so30657185vnb.2 for ; Wed, 08 Jul 2015 04:09:29 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1436348808-223033-8-git-send-email-imammedo@redhat.com> References: <1436348808-223033-1-git-send-email-imammedo@redhat.com> <1436348808-223033-8-git-send-email-imammedo@redhat.com> From: Peter Maydell Date: Wed, 8 Jul 2015 12:09:10 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [RFC v3 7/8] memory: extend memory_region_add_subregion() to support error reporting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: Paolo Bonzini , QEMU Developers , "Michael S. Tsirkin" On 8 July 2015 at 10:46, Igor Mammedov wrote: > extends memory_region_add_subregion() by adding Error** > argument to allow t fail and return a error from it. > > Signed-off-by: Igor Mammedov > 156 files changed, 619 insertions(+), 420 deletions(-) This is a seriously invasive API change and I don't really like it -- reconfiguring the memory region hierarchy should not be an operation which can fail (especially not just adding a subregion!) -- PMM