From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42359)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YDDoq-00089r-Tv
	for qemu-devel@nongnu.org; Mon, 19 Jan 2015 10:00:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YDDon-0007uv-DA
	for qemu-devel@nongnu.org; Mon, 19 Jan 2015 10:00:44 -0500
Received: from mail-la0-f48.google.com ([209.85.215.48]:35162)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YDDon-0007uc-5t
	for qemu-devel@nongnu.org; Mon, 19 Jan 2015 10:00:41 -0500
Received: by mail-la0-f48.google.com with SMTP id gf13so29171648lab.7
	for <qemu-devel@nongnu.org>; Mon, 19 Jan 2015 07:00:40 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1421672109-29467-1-git-send-email-kraxel@redhat.com>
References: <1421672109-29467-1-git-send-email-kraxel@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 19 Jan 2015 15:00:18 +0000
Message-ID: <CAFEAcA8yP0LL9kOEPQv095ETRGXfwPrWfTzFOtZNNfh31G2-kA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PULL 0/8] ui: add shared surface format
	negotiation.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 19 January 2015 at 12:55, Gerd Hoffmann <kraxel@redhat.com> wrote:
>   Hi,
>
> This patch series allows display device emulations to negotiate with
> the UI code which pixman formats it can handle for shared surfaces.
>
> Based on patches from Benjamin Herrenschmidt, sent to the list for
> review ten days ago, here we go with the pull request.
>
> please pull,
>   Gerd
>
> The following changes since commit 1e42c353469cb58ca4f3b450eea4211af7d0b147:
>
>   Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20150116' into staging (2015-01-16 12:06:41 +0000)
>
> are available in the git repository at:
>
>
>   git://git.kraxel.org/qemu tags/pull-console-20150119-1
>
> for you to fetch changes up to 877417d9ae6846bea4744b198131a5fe5117d7a5:
>
>   ui/sdl2: Support shared surface for more pixman formats (2015-01-19 13:33:26 +0100)

Applied, thanks.

You forgot to add your maintainer's signoff to one of Ben's patches.
Since it was a one-liner I didn't think it was worth bouncing the
pullreq for, but you might want to consider adding something to your
pre-pull sanity checks. I use:

if ! git rev-list HEAD | grep -q $(git rev-parse master) ; then
    echo "master is not a parent commit of $BRANCH -- rebase!"
    exit 1
fi
# Check all commits have our signoff
bad=no
for rev in $(git rev-list master..HEAD); do
    if git log ${rev}^! | grep -q "Signed-off-by: $SIGNOFF"; then
       continue
    fi
    echo "Error: commit ${rev} missing signoff"
    bad=yes
done
if [ "$bad" = "yes" ]; then
   exit 1
fi

thanks
-- PMM