From: Peter Maydell <peter.maydell@linaro.org>
To: Subbaraya Sundeep <sundeep.lkml@gmail.com>
Cc: "QEMU Developers" <qemu-devel@nongnu.org>,
qemu-arm <qemu-arm@nongnu.org>,
"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
"Alistair Francis" <alistair23@gmail.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Igor Mammedov" <imammedo@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
darren.kenny@oracle.com
Subject: Re: [Qemu-devel] [Qemu devel V4 PATCH] msf2: Remove dead code reported by Coverity
Date: Mon, 30 Oct 2017 09:58:43 +0000 [thread overview]
Message-ID: <CAFEAcA8yX6QKngPT8sbssDo+UOsH9cyCshrXigMkwTk2uoNWmw@mail.gmail.com> (raw)
In-Reply-To: <1508898544-10307-1-git-send-email-sundeep.lkml@gmail.com>
On 25 October 2017 at 03:29, Subbaraya Sundeep <sundeep.lkml@gmail.com> wrote:
> Fixed incorrect frame size mask, validated maximum frame
> size in spi_write and removed dead code.
>
> Signed-off-by: Subbaraya Sundeep <sundeep.lkml@gmail.com>
> ---
> v4:
> changed %d to %u while logging frame size error.
> v3:
> Added comment that [31:6] bits are reserved in R_SPI_DFSIZE
> register and logged incorrect value too in guest error(suggested
> by Darren).
> v2:
> else if -> else in set_fifodepth
> log guest error when frame size is more than 32
>
> hw/ssi/mss-spi.c | 18 ++++++++++++++----
> 1 file changed, 14 insertions(+), 4 deletions(-)
>
Applied to target-arm.next, thanks.
-- PMM
prev parent reply other threads:[~2017-10-30 9:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 2:29 [Qemu-devel] [Qemu devel V4 PATCH] msf2: Remove dead code reported by Coverity Subbaraya Sundeep
2017-10-25 8:45 ` Darren Kenny
2017-10-26 5:59 ` sundeep subbaraya
2017-10-26 9:37 ` Alistair Francis
2017-10-30 9:58 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8yX6QKngPT8sbssDo+UOsH9cyCshrXigMkwTk2uoNWmw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=alistair23@gmail.com \
--cc=crosthwaite.peter@gmail.com \
--cc=darren.kenny@oracle.com \
--cc=f4bug@amsat.org \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sundeep.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).