From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35649) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e96qX-0006nM-QI for qemu-devel@nongnu.org; Mon, 30 Oct 2017 05:59:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e96qX-0003L6-6U for qemu-devel@nongnu.org; Mon, 30 Oct 2017 05:59:05 -0400 Received: from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]:45330) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e96qX-0003K9-00 for qemu-devel@nongnu.org; Mon, 30 Oct 2017 05:59:05 -0400 Received: by mail-wm0-x230.google.com with SMTP id y80so7777155wmd.0 for ; Mon, 30 Oct 2017 02:59:04 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1508898544-10307-1-git-send-email-sundeep.lkml@gmail.com> References: <1508898544-10307-1-git-send-email-sundeep.lkml@gmail.com> From: Peter Maydell Date: Mon, 30 Oct 2017 09:58:43 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [Qemu devel V4 PATCH] msf2: Remove dead code reported by Coverity List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Subbaraya Sundeep Cc: QEMU Developers , qemu-arm , Peter Crosthwaite , Alistair Francis , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Igor Mammedov , Paolo Bonzini , darren.kenny@oracle.com On 25 October 2017 at 03:29, Subbaraya Sundeep wrote: > Fixed incorrect frame size mask, validated maximum frame > size in spi_write and removed dead code. > > Signed-off-by: Subbaraya Sundeep > --- > v4: > changed %d to %u while logging frame size error. > v3: > Added comment that [31:6] bits are reserved in R_SPI_DFSIZE > register and logged incorrect value too in guest error(suggested > by Darren). > v2: > else if -> else in set_fifodepth > log guest error when frame size is more than 32 > > hw/ssi/mss-spi.c | 18 ++++++++++++++---- > 1 file changed, 14 insertions(+), 4 deletions(-) > Applied to target-arm.next, thanks. -- PMM