From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41351)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Vo0Em-0007Pr-9O
	for qemu-devel@nongnu.org; Tue, 03 Dec 2013 19:22:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Vo0Eg-0003Pq-SH
	for qemu-devel@nongnu.org; Tue, 03 Dec 2013 19:22:44 -0500
Received: from mail-pd0-f173.google.com ([209.85.192.173]:63242)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Vo0Eg-0003Pm-Mq
	for qemu-devel@nongnu.org; Tue, 03 Dec 2013 19:22:38 -0500
Received: by mail-pd0-f173.google.com with SMTP id p10so21164571pdj.18
	for <qemu-devel@nongnu.org>; Tue, 03 Dec 2013 16:22:38 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <529E7141.2050203@twiddle.net>
References: <1386107477-24165-1-git-send-email-peter.maydell@linaro.org>
	<1386107477-24165-11-git-send-email-peter.maydell@linaro.org>
	<529E7141.2050203@twiddle.net>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Wed, 4 Dec 2013 00:22:17 +0000
Message-ID: <CAFEAcA8z0GDo7szzsOCesSCt2c4oR43SvAw5Avr+X+M+VfB8oA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 10/12] target-arm: A64: add support for
	conditional branches
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: Patch Tracking <patches@linaro.org>, Michael Matz <matz@suse.de>, Alexander Graf <agraf@suse.de>, QEMU Developers <qemu-devel@nongnu.org>, C Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Laurent Desnogues <laurent.desnogues@gmail.com>, "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>

On 4 December 2013 00:03, Richard Henderson <rth@twiddle.net> wrote:
> On 12/04/2013 10:51 AM, Peter Maydell wrote:
>> +    if (cond < 0x0e) {
>> +        /* genuinely conditional branches */
>> +        int label_nomatch = gen_new_label();
>> +        arm_gen_test_cc(cond ^ 1, label_nomatch);
>> +        gen_goto_tb(s, 0, addr);
>> +        gen_set_label(label_nomatch);
>> +        gen_goto_tb(s, 1, s->pc);
>
> Why swap the condition with "^ 1"?  You can just as easily swap the goto_tb.  I
> realize the A32 translator does it this way, but need we continue?

Good point; will change.

thanks
-- PMM