From: Peter Maydell <peter.maydell@linaro.org>
To: Laurent Vivier <laurent@vivier.eu>
Cc: Riku Voipio <riku.voipio@iki.fi>,
QEMU Developers <qemu-devel@nongnu.org>,
pgndev <pgnet.dev@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] linux-user: Fix TARGET_MTIOCTOP/MTIOCGET/MTIOCPOS values
Date: Mon, 16 Oct 2017 14:26:27 +0100 [thread overview]
Message-ID: <CAFEAcA8z17CSarERraA2+QsakzPx-RioJNX=+e7_8pf_MUqVnA@mail.gmail.com> (raw)
In-Reply-To: <4d8c3811-62a9-2391-e962-736c333d45c6@vivier.eu>
On 16 October 2017 at 14:09, Laurent Vivier <laurent@vivier.eu> wrote:
> For this part, yes, but I think for the other comment, STRUCT(mtget,
> ...) needs to be updated.
Looking more closely I don't think it is as simple as just
adjusting the STRUCT() definition. For a basic type that can
be different on host and guest, I think we'd need to handle
it the way we do the TYPE_OLDDEVT, with special support
in the thunk code for figuring out how large it is and so on.
That seems like a lot of work for a magtape ioctl that I
suspect nobody's using and which we can't test...
Applying this patch as-is would at least fix the ioctl
for everything except MIPS and SPARC hosts and guests.
thanks
-- PMM
next prev parent reply other threads:[~2017-10-16 13:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 15:30 [Qemu-devel] [PATCH 0/2] fix incorrect target ioctl numbers Peter Maydell
2017-10-12 15:30 ` [Qemu-devel] [PATCH 1/2] linux-user: Fix target FS_IOC_GETFLAGS and FS_IOC_SETFLAGS numbers Peter Maydell
2017-10-12 16:34 ` Laurent Vivier
2017-10-16 13:05 ` Riku Voipio
2017-10-12 15:30 ` [Qemu-devel] [PATCH 2/2] linux-user: Fix TARGET_MTIOCTOP/MTIOCGET/MTIOCPOS values Peter Maydell
2017-10-12 16:49 ` Laurent Vivier
2017-10-12 16:53 ` Peter Maydell
2017-10-12 17:08 ` Laurent Vivier
2017-10-16 13:06 ` Riku Voipio
2017-10-16 13:09 ` Laurent Vivier
2017-10-16 13:26 ` Peter Maydell [this message]
2017-10-16 13:29 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8z17CSarERraA2+QsakzPx-RioJNX=+e7_8pf_MUqVnA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=laurent@vivier.eu \
--cc=pgnet.dev@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).